Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 740653006: Convert MakeWebEvent parameter types (Closed)

Created:
6 years, 1 month ago by Andre
Modified:
6 years ago
Reviewers:
sadrul
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

The parameter types are changed from pointer types to const reference types, for the purpose of reducing the need for conversions and const_cast at call sites. Committed: https://crrev.com/5f6a162270d0ca56437ea78353e32ab40b060122 Cr-Commit-Position: refs/heads/master@{#305444}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -107 lines) Patch
M content/browser/renderer_host/native_web_keyboard_event_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 8 chunks +9 lines, -10 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 11 chunks +86 lines, -84 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Andre
Sadrul PTAL. As discussed in https://codereview.chromium.org/739993002/.
6 years, 1 month ago (2014-11-22 00:08:25 UTC) #3
sadrul
Thanks! LGTM
6 years, 1 month ago (2014-11-24 06:16:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740653006/20001
6 years ago (2014-11-24 16:37:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years ago (2014-11-24 17:49:36 UTC) #7
commit-bot: I haz the power
6 years ago (2014-11-24 17:52:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f6a162270d0ca56437ea78353e32ab40b060122
Cr-Commit-Position: refs/heads/master@{#305444}

Powered by Google App Engine
This is Rietveld 408576698