Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 740653005: Remove implicit conversions from scoped_refptr to T* in win8/ (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in win8/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 Committed: https://crrev.com/aad41eecdd47c0ec9504be1e5bf5ec0b07b167f7 Cr-Commit-Position: refs/heads/master@{#305279}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -56 lines) Patch
M win8/delegate_execute/delegate_execute.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M win8/metro_driver/ime/input_source.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M win8/metro_driver/ime/text_service.cc View 1 8 chunks +13 lines, -17 lines 0 comments Download
M win8/metro_driver/ime/text_store.cc View 1 9 chunks +14 lines, -14 lines 0 comments Download
M win8/test/ui_automation_client.cc View 5 chunks +8 lines, -16 lines 0 comments Download
M win8/viewer/metro_viewer_process_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dcheng
6 years, 1 month ago (2014-11-21 16:58:26 UTC) #2
grt (UTC plus 2)
https://codereview.chromium.org/740653005/diff/1/win8/metro_driver/ime/text_service.cc File win8/metro_driver/ime/text_service.cc (right): https://codereview.chromium.org/740653005/diff/1/win8/metro_driver/ime/text_service.cc#newcode341 win8/metro_driver/ime/text_service.cc:341: if (!text_store) shouldn't this be: if (!text_store.get()) ? https://codereview.chromium.org/740653005/diff/1/win8/metro_driver/ime/text_store.cc ...
6 years, 1 month ago (2014-11-21 17:28:58 UTC) #3
dcheng
https://codereview.chromium.org/740653005/diff/1/win8/metro_driver/ime/text_service.cc File win8/metro_driver/ime/text_service.cc (right): https://codereview.chromium.org/740653005/diff/1/win8/metro_driver/ime/text_service.cc#newcode341 win8/metro_driver/ime/text_service.cc:341: if (!text_store) On 2014/11/21 17:28:57, grt wrote: > shouldn't ...
6 years, 1 month ago (2014-11-21 17:35:20 UTC) #4
grt (UTC plus 2)
thanks, lgtm.
6 years, 1 month ago (2014-11-21 17:55:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740653005/20001
6 years, 1 month ago (2014-11-21 19:13:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-21 21:09:06 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 21:09:58 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aad41eecdd47c0ec9504be1e5bf5ec0b07b167f7
Cr-Commit-Position: refs/heads/master@{#305279}

Powered by Google App Engine
This is Rietveld 408576698