Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 740653002: Reland: 185196 Fix CPU(32BIT) definition (Closed)

Created:
6 years, 1 month ago by hiroshige
Modified:
6 years ago
Reviewers:
Tom Sepez, Chris Evans
CC:
blink-reviews, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Reland: 185196 Fix CPU(32BIT) definition Previously WTF_CPU_32BIT definition is inside #if of ARM. This CL make CPU(32BIT) true on all architectures if and only if not CPU(64BIT). This CL enables the change in Revision 185559 on 32-bit Windows. BUG=432033, 394591 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/wtf/CPU.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
hiroshige
cevans@, could you take a look as a wtf/ owner? tsepez@, could you put this ...
6 years, 1 month ago (2014-11-19 04:57:57 UTC) #2
Chris Evans
On 2014/11/19 04:57:57, hiroshige wrote: > cevans@, could you take a look as a wtf/ ...
6 years, 1 month ago (2014-11-19 05:03:28 UTC) #3
Tom Sepez
> Ah, we probably landed things in the wrong order again :D Indeed. I thought ...
6 years, 1 month ago (2014-11-19 17:55:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740653002/1
6 years ago (2014-12-15 09:11:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=187134
6 years ago (2014-12-15 11:53:53 UTC) #7
hiroshige
Crashed all? XP layout tests. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/15774
6 years ago (2014-12-15 13:02:00 UTC) #8
hiroshige
6 years ago (2014-12-15 13:05:25 UTC) #9
Message was sent while issue was closed.
Reverted: https://codereview.chromium.org/806683003/.

Powered by Google App Engine
This is Rietveld 408576698