Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 740633006: [bisect] - Let perf try jobs specify revisions to test. (Closed)

Created:
6 years ago by shatch
Modified:
6 years ago
Reviewers:
prasadv
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[bisect] - Let perf try jobs specify revisions to test. Previously the perf try bots always used ToT and built with/without patch. This CL lets you specify a before/after revision instead, so that we can kick off perf try jobs with traces from the dashboard. Also did some refactoring to break up _RunPerformanceTest a bit. BUG=433456 TEST= Revisions Specified: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/1088 Existing: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/1087 Committed: https://crrev.com/88ed7eb5bc494aa90ebc92709c98e97abfa39821 Cr-Commit-Position: refs/heads/master@{#306427}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -67 lines) Patch
M tools/run-bisect-perf-regression.py View 4 chunks +125 lines, -67 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
shatch
6 years ago (2014-12-02 17:12:32 UTC) #17
prasadv
lgtm
6 years ago (2014-12-02 18:00:58 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740633006/260001
6 years ago (2014-12-02 18:24:04 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:260001)
6 years ago (2014-12-02 19:01:32 UTC) #21
commit-bot: I haz the power
6 years ago (2014-12-02 19:02:12 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88ed7eb5bc494aa90ebc92709c98e97abfa39821
Cr-Commit-Position: refs/heads/master@{#306427}

Powered by Google App Engine
This is Rietveld 408576698