Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: masters/master.chromium.gpu.fyi/master.cfg

Issue 74063005: Switched remaining GPU test bots to be pure testers, triggered by builders. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Addressed stip's review feedback. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | masters/master.chromium.gpu.fyi/slaves.cfg » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: masters/master.chromium.gpu.fyi/master.cfg
diff --git a/masters/master.chromium.gpu.fyi/master.cfg b/masters/master.chromium.gpu.fyi/master.cfg
index 57454e70f68bdc1d46574ef9099f99eec4019d6f..5a6ec4528d01633532fc87375865dec4ae358555 100644
--- a/masters/master.chromium.gpu.fyi/master.cfg
+++ b/masters/master.chromium.gpu.fyi/master.cfg
@@ -4,13 +4,13 @@
from buildbot.changes import svnpoller
from buildbot.scheduler import Dependent
-from buildbot.scheduler import Scheduler
from common import chromium_utils
from master import build_utils
from master import master_config
from master import master_utils
+from master import recipe_master_helper
from master import slaves_list
from master.factory import annotator_factory
from master.factory import chromium_factory
@@ -69,12 +69,8 @@ slaves = slaves_list.SlavesList('slaves.cfg', 'ChromiumGPUFYI')
# Main scheduler for all changes in trunk.
-builderNames = sorted(slave['builder'] for slave in slaves.slaves)
-s_gpu = Scheduler(name='gpu',
- branch='src',
- treeStableTimer=60,
- builderNames=builderNames)
-c['schedulers'] = [s_gpu]
+trigger_name_map = recipe_master_helper.AddSchedulersAndTriggers(
+ buildmaster_config=c, slave_list=slaves, scheduler_name='gpu', branch='src')
####### BUILDERS
@@ -125,23 +121,8 @@ f_linux_audio_rel = F_LINUX_AUDIO(
# ----------------------------------------------------------------------------
# BUILDER DEFINITIONS
-gpu_builders = []
-for slave in slaves.slaves:
- if 'recipe' in slave:
- factory_properties = {
- 'test_results_server': 'test-results.appspot.com',
- 'generate_gtest_json': True,
- 'build_config': slave['build_config']
- }
- if 'perf_id' in slave:
- factory_properties['show_perf_results'] = True
- factory_properties['perf_id'] = slave['perf_id']
- gpu_builders.append({
- 'name': slave['builder'],
- 'factory': m_annotator.BaseFactory(
- slave['recipe'],
- factory_properties)
- })
+recipe_master_helper.AddRecipeBasedBuilders(
+ c, slaves, m_annotator, trigger_name_map)
b_win_audio = {'name': 'Win7 Audio',
'factory': f_win_audio_rel}
@@ -150,7 +131,7 @@ b_linux_audio = {'name': 'Linux Audio',
'factory': f_linux_audio_rel}
# Order them by OS type, target type, and OS version.
-c['builders'] = gpu_builders + [ b_win_audio, b_linux_audio ]
+c['builders'] += [ b_win_audio, b_linux_audio ]
# Associate the slaves to the manual builders. The configuration is in
# slaves.cfg.
« no previous file with comments | « no previous file | masters/master.chromium.gpu.fyi/slaves.cfg » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698