DevTools: Support asynchronous call stacks on backend.

Source/core/inspector/AsyncCallStackTracker.h

+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef AsyncCallStackTracker_h
+#define AsyncCallStackTracker_h
+
+#include "bindings/v8/ScriptValue.h"
+#include "wtf/Deque.h"
+#include "wtf/FastAllocBase.h"
+#include "wtf/HashMap.h"
+#include "wtf/HashSet.h"
+#include "wtf/Noncopyable.h"
+#include "wtf/PassRefPtr.h"
+#include "wtf/RefPtr.h"
+
+namespace WebCore {
+
+class AsyncCallStackTracker {
+    WTF_MAKE_NONCOPYABLE(AsyncCallStackTracker); WTF_MAKE_FAST_ALLOCATED;

[yurys, 2013/12/03 13:41:08]

Why does it need to be marked as WTF_MAKE_FAST_ALLOCATED ?

[aandrey, 2013/12/04 12:45:47]

removed

+private:
+    struct AsyncCallStack : public RefCounted<AsyncCallStack> {

[yurys, 2013/12/03 13:41:08]

You can leave only forward declaration of the structs here in the header and
move actual declaration to the .cpp

[aandrey, 2013/12/04 12:45:47]

its became part of public API

+        AsyncCallStack();
+        ~AsyncCallStack();
+        ScriptValue m_callFrames;
+    };
+
+    typedef Deque<RefPtr<AsyncCallStack>, 4> AsyncCallStackVector;
+
+    struct AsyncCallTrace : public RefCounted<AsyncCallTrace> {

[yurys, 2013/12/03 13:41:08]

Maybe AsyncCallStackChain or AsyncCallChain?

[aandrey, 2013/12/04 12:45:47]

renamed to AsyncCallChain

+        AsyncCallTrace() { }
+        AsyncCallTrace(const AsyncCallTrace& t) : m_callStacks(t.m_callStacks) { }
+        AsyncCallStackVector m_callStacks;
+    };
+
+public:
+    class AsyncCallTraceIterator {
+    public:
+        bool hasNext() const;
+        ScriptValue next();
+
+    private:
+        friend class AsyncCallStackTracker;
+        AsyncCallTraceIterator() { }
+        AsyncCallTraceIterator(const AsyncCallTrace& t) : m_callStacks(t.m_callStacks) { }

[yurys, 2013/12/03 13:41:08]

How is this iterator going to be used? Wouldn't it be more clear to use
AsyncCallTrace directly?

[aandrey, 2013/12/04 12:45:47]

Done.

+        AsyncCallStackVector m_callStacks;
+    };
+
+    AsyncCallStackTracker();
+
+    inline bool isEnabled() const { return m_maxAsyncCallStackDepth; }

[yurys, 2013/12/03 13:41:08]

Please remove 'inline' as it doesn't add anything.

[aandrey, 2013/12/04 12:45:47]

Done.

+    void setAsyncCallStackDepth(int);
+    AsyncCallTraceIterator currentAsyncCallStack();
+
+    void didInstallTimer(int timerId, bool singleShot);
+    void didRemoveTimer(int timerId);
+    void willFireTimer(int timerId);
+
+    void didRequestAnimationFrame(int callbackId);
+    void didCancelAnimationFrame(int callbackId);
+    void willFireAnimationFrame(int callbackId);
+
+    void didAsyncCall();
+    void didRequestAsyncCallFrames(ScriptValue callFrames);

[yurys, 2013/12/03 13:41:08]

setCurrentCallStack ?

+
+    void clear();
+
+private:
+    PassRefPtr<AsyncCallTrace> createAsyncCallTrace();
+    static void ensureMaxAsyncCallTraceDepth(AsyncCallTrace*, unsigned);
+
+    unsigned m_maxAsyncCallStackDepth;
+    RefPtr<AsyncCallStack> m_requestedAsyncCallStack;
+    RefPtr<AsyncCallTrace> m_currentAsyncCallTrace;
+    HashSet<int> m_intervalTimerIds;
+    HashMap<int, RefPtr<AsyncCallTrace> > m_timerCallTraces;
+    HashMap<int, RefPtr<AsyncCallTrace> > m_animationFrameCallTraces;
+};
+
+} // namespace WebCore
+
+#endif // !defined(AsyncCallStackTracker_h)