Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1521)

Unified Diff: content/shell/renderer/test_runner/test_runner.cc

Issue 740543003: Remove the old Web Notification code-path (Chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unittest references Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/test_runner/test_runner.cc
diff --git a/content/shell/renderer/test_runner/test_runner.cc b/content/shell/renderer/test_runner/test_runner.cc
index 869cc81368207e5c1e7623a8486ac436b8184bc0..d4e59240c14e8b682fdf50259aa4cab683c7dda0 100644
--- a/content/shell/renderer/test_runner/test_runner.cc
+++ b/content/shell/renderer/test_runner/test_runner.cc
@@ -13,7 +13,6 @@
#include "content/shell/renderer/test_runner/mock_credential_manager_client.h"
#include "content/shell/renderer/test_runner/mock_web_push_client.h"
#include "content/shell/renderer/test_runner/mock_web_speech_recognizer.h"
-#include "content/shell/renderer/test_runner/notification_presenter.h"
#include "content/shell/renderer/test_runner/test_interfaces.h"
#include "content/shell/renderer/test_runner/web_permissions.h"
#include "content/shell/renderer/test_runner/web_test_delegate.h"
@@ -1547,7 +1546,6 @@ TestRunner::TestRunner(TestInterfaces* interfaces)
web_view_(nullptr),
page_overlay_(nullptr),
web_permissions_(new WebPermissions()),
- notification_presenter_(new NotificationPresenter()),
weak_factory_(this) {}
TestRunner::~TestRunner() {}
@@ -1559,7 +1557,6 @@ void TestRunner::Install(WebFrame* frame) {
void TestRunner::SetDelegate(WebTestDelegate* delegate) {
delegate_ = delegate;
web_permissions_->SetDelegate(delegate);
- notification_presenter_->set_delegate(delegate);
}
void TestRunner::SetWebView(WebView* webView, WebTestProxyBase* proxy) {
@@ -1659,7 +1656,6 @@ void TestRunner::Reset() {
web_permissions_->Reset();
- notification_presenter_->Reset();
use_mock_theme_ = true;
pointer_locked_ = false;
pointer_lock_planned_result_ = PointerLockWillSucceed;
@@ -1879,10 +1875,6 @@ bool TestRunner::shouldDumpResourcePriorities() const {
return should_dump_resource_priorities_;
}
-WebNotificationPresenter* TestRunner::notification_presenter() const {
- return notification_presenter_.get();
-}
-
bool TestRunner::RequestPointerLock() {
switch (pointer_lock_planned_result_) {
case PointerLockWillSucceed:
@@ -2776,10 +2768,6 @@ void TestRunner::ClearWebNotificationPermissions() {
void TestRunner::SimulateWebNotificationClick(const std::string& title) {
delegate_->SimulateWebNotificationClick(title);
-
- // TODO(peter): Remove this call once Web Notifications switch away from the
- // WebFrame-based code path.
- notification_presenter_->SimulateClick(title);
}
void TestRunner::AddMockSpeechRecognitionResult(const std::string& transcript,
« no previous file with comments | « content/shell/renderer/test_runner/test_runner.h ('k') | content/shell/renderer/test_runner/web_frame_test_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698