Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 740543003: Remove the old Web Notification code-path (Chromium) (Closed)

Created:
6 years, 1 month ago by Peter Beverloo
Modified:
6 years, 1 month ago
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove the old Web Notification code-path (Chromium) This patch removes the old Web Notifications code-path now that we've switched to the new Workers-enabled path. BUG=392187 Committed: https://crrev.com/d98157d4fd58eadbc20a2e66e1f9ea123c27e612 Cr-Commit-Position: refs/heads/master@{#305005}

Patch Set 1 #

Patch Set 2 : more things to remove #

Patch Set 3 : remove the ipc message #

Patch Set 4 : fix the gn build #

Patch Set 5 : remove unittest references #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -982 lines) Patch
M content/browser/frame_host/render_frame_host_impl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 5 chunks +0 lines, -82 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 5 chunks +0 lines, -16 lines 0 comments Download
M content/common/content_message_generator.h View 1 1 chunk +0 lines, -1 line 0 comments Download
D content/common/desktop_notification_messages.h View 1 1 chunk +0 lines, -49 lines 0 comments Download
M content/common/platform_notification_messages.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 3 chunks +0 lines, -12 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
D content/renderer/active_notification_tracker.h View 1 chunk +0 lines, -47 lines 0 comments Download
D content/renderer/active_notification_tracker.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D content/renderer/active_notification_tracker_unittest.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D content/renderer/notification_icon_loader.h View 1 chunk +0 lines, -73 lines 0 comments Download
D content/renderer/notification_icon_loader.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D content/renderer/notification_provider.h View 1 chunk +0 lines, -66 lines 0 comments Download
D content/renderer/notification_provider.cc View 1 chunk +0 lines, -165 lines 0 comments Download
M content/renderer/render_frame_impl.h View 4 chunks +0 lines, -7 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 4 chunks +0 lines, -10 lines 0 comments Download
M content/shell/BUILD.gn View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_message_filter.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M content/shell/common/layout_test/layout_test_messages.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/renderer/layout_test/webkit_test_runner.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/webkit_test_runner.cc View 1 chunk +0 lines, -10 lines 0 comments Download
D content/shell/renderer/test_runner/notification_presenter.h View 1 chunk +0 lines, -55 lines 0 comments Download
D content/shell/renderer/test_runner/notification_presenter.cc View 1 chunk +0 lines, -133 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 5 chunks +1 line, -6 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 6 chunks +0 lines, -12 lines 0 comments Download
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_delegate.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/ipc_message_start.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Peter Beverloo
\o/
6 years, 1 month ago (2014-11-19 12:43:40 UTC) #2
Peter Beverloo
+mkwst for IPC
6 years, 1 month ago (2014-11-19 12:53:31 UTC) #4
Mike West
IPC LGTM. I only skimmed the rest, but it looks reasonable too.
6 years, 1 month ago (2014-11-19 16:21:34 UTC) #5
Avi (use Gerrit)
Remove ,, ';; '' ____ || ; \ || \,---'-,-, || / ( o) || ...
6 years, 1 month ago (2014-11-19 16:36:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740543003/80001
6 years, 1 month ago (2014-11-20 12:30:00 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 1 month ago (2014-11-20 13:15:10 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 13:15:54 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d98157d4fd58eadbc20a2e66e1f9ea123c27e612
Cr-Commit-Position: refs/heads/master@{#305005}

Powered by Google App Engine
This is Rietveld 408576698