Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 740493002: Forward declaration for Isolate / Platform in libplatform.h. (Closed)

Created:
6 years, 1 month ago by bulach
Modified:
6 years, 1 month ago
CC:
v8-dev, Paweł Hajdan Jr., ulan
Project:
v8
Visibility:
Public.

Description

Forward declaration for Isolate / Platform in libplatform.h. Reduces dependencies on #include files, making it easier for other build systems to include this library. BUG= Committed: https://chromium.googlesource.com/v8/v8/+/6dafd81ae2a1848e276dd38aa51bb0acd2e7a19a

Patch Set 1 #

Patch Set 2 : Adds includes in a few .cc files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M include/libplatform/libplatform.h View 1 chunk +4 lines, -2 lines 0 comments Download
M samples/lineprocessor.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M samples/shell.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/run-all-unittests.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
bulach
hello again :) this will make my life easier on "the other side", please let ...
6 years, 1 month ago (2014-11-18 19:24:10 UTC) #2
jochen (gone - plz use gerrit)
lgtm.
6 years, 1 month ago (2014-11-18 19:27:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740493002/1
6 years, 1 month ago (2014-11-18 19:28:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/1372)
6 years, 1 month ago (2014-11-18 19:37:03 UTC) #7
bulach
On 2014/11/18 19:37:03, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 1 month ago (2014-11-18 19:37:52 UTC) #8
bulach
another look please?
6 years, 1 month ago (2014-11-18 19:48:37 UTC) #9
jochen (gone - plz use gerrit)
still lgtm
6 years, 1 month ago (2014-11-18 20:00:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740493002/20001
6 years, 1 month ago (2014-11-18 20:01:42 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 20:29:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698