Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 740463005: grit: Use new --write-only-new flag. (Closed)

Created:
6 years ago by Nico
Modified:
6 years ago
Reviewers:
brettw, newt (away)
CC:
aandrey+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, dsinclair+watch_chromium.org, jam, paulirish+reviews_chromium.org, pfeldman, vsevik, wfh+watch_chromium.org, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

grit: Use new --write-only-new flag. For the file I'm testing with (c/b/resources/about_stats.html), a rebuild runs 101 edges and compiles a bunch of cc files and takes 40s. This reduces build times from 40s to 9.6s and reduces the number of edges to 37. BUG=439182 R=brettw@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/9261dde33f1939f432cafe6f9654efedba4dc252

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M build/grit_action.gypi View 2 chunks +15 lines, -0 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/devtools_resources.gyp View 1 2 chunks +16 lines, -0 lines 0 comments Download
M content/browser/tracing/tracing_resources.gyp View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
6 years ago (2014-12-04 23:47:30 UTC) #2
brettw
lgtm
6 years ago (2014-12-04 23:50:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740463005/20001
6 years ago (2014-12-05 00:04:35 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9261dde33f1939f432cafe6f9654efedba4dc252 Cr-Commit-Position: refs/heads/master@{#306945}
6 years ago (2014-12-05 00:50:42 UTC) #6
Nico
6 years ago (2014-12-05 00:50:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9261dde33f1939f432cafe6f9654efedba4dc252 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698