Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 740463002: fix for use of uninit variable (Closed)

Created:
6 years, 1 month ago by joshua.litt
Modified:
6 years, 1 month ago
Reviewers:
joshualitt
CC:
reviews_skia.org, bsalomon
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

fix for use of uninit variable TBR= BUG=skia: Committed: https://skia.googlesource.com/skia/+/780b11e4ec3e793c1e80443cf2d1f7119fe9c565

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/gpu/GrBitmapTextContext.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 chunk +5 lines, -5 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740463002/1
6 years, 1 month ago (2014-11-18 17:32:16 UTC) #2
tfarina
https://codereview.chromium.org/740463002/diff/1/src/gpu/GrDistanceFieldTextContext.cpp File src/gpu/GrDistanceFieldTextContext.cpp (right): https://codereview.chromium.org/740463002/diff/1/src/gpu/GrDistanceFieldTextContext.cpp#newcode640 src/gpu/GrDistanceFieldTextContext.cpp:640: drawState.setFromPaint(fPaint, fContext->getMatrix(), fContext->getRenderTarget()); is fContext NULL if fCurrVertex is ...
6 years, 1 month ago (2014-11-18 17:35:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/780b11e4ec3e793c1e80443cf2d1f7119fe9c565
6 years, 1 month ago (2014-11-18 17:40:45 UTC) #4
joshualitt
6 years, 1 month ago (2014-11-18 17:46:14 UTC) #5
Message was sent while issue was closed. 
On 2014/11/18 17:40:45, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1) as
> https://skia.googlesource.com/skia/+/780b11e4ec3e793c1e80443cf2d1f7119fe9c565

Err, in bitmap textcontext it was fCurrMask.  If fCurrVertex == 0 though, we
haven't drawn anything so there is no reason to do the 'setFromPaint' in that
case.

Powered by Google App Engine
This is Rietveld 408576698