Source/bindings/templates/dictionary_impl.h - Issue 740453004: IDL: Basic dictionary inheritance support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/dictionary_impl.h

Issue 740453004: IDL: Basic dictionary inheritance support (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/templates/dictionary_impl.h

diff --git a/Source/bindings/templates/dictionary_impl.h b/Source/bindings/templates/dictionary_impl.h

index 9cdea3d4cc10829e56e1fd4f85028554847dfb02..b52b1c44aa56991fc49144d39cadc8b9278ae597 100644

--- a/Source/bindings/templates/dictionary_impl.h

+++ b/Source/bindings/templates/dictionary_impl.h

@@ -13,7 +13,8 @@

namespace blink {

-class {{cpp_class}} final {

+{# FIXME: Add "final" if this class doesn't have subclasses #}

+class {{cpp_class}}{% if parent_cpp_class %} : public {{parent_cpp_class}}{% endif %} {

ALLOW_ONLY_INLINE_ALLOCATION();

public:

{{cpp_class}}();

@@ -24,7 +25,7 @@ public:

void {{member.setter_name}}({{member.rvalue_cpp_type}} value) { m_{{member.cpp_name}} = value; }

{% endfor %}

- void trace(Visitor*);

+ virtual void trace(Visitor*);

private:

{% for member in members %}