Source/bindings/templates/dictionary_impl.cpp - Issue 740453004: IDL: Basic dictionary inheritance support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/dictionary_impl.cpp

Issue 740453004: IDL: Basic dictionary inheritance support (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/templates/dictionary_impl.cpp

diff --git a/Source/bindings/templates/dictionary_impl.cpp b/Source/bindings/templates/dictionary_impl.cpp

index 60e56ec938cbf511e5274db520ef52f710761c52..d562867bd6bf8c06ccec769f17aa51c2b1511a84 100644

--- a/Source/bindings/templates/dictionary_impl.cpp

+++ b/Source/bindings/templates/dictionary_impl.cpp

@@ -23,6 +23,9 @@ namespace blink {

void {{cpp_class}}::trace(Visitor* visitor)

{

+ {% if parent_cpp_class %}

+ {{parent_cpp_class}}::trace(visitor);

haraken 2014/11/19 09:11:26 Would you move this down to the tail of this trace

bashi 2014/11/19 11:04:42 Done.

+ {% endif %}

{% for member in members if member.is_traceable %}

visitor->trace(m_{{member.cpp_name}});

{% endfor %}