Source/bindings/scripts/code_generator_v8.py - Issue 740453004: IDL: Basic dictionary inheritance support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/code_generator_v8.py

Issue 740453004: IDL: Basic dictionary inheritance support (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/code_generator_v8.py

diff --git a/Source/bindings/scripts/code_generator_v8.py b/Source/bindings/scripts/code_generator_v8.py

index b34cfcb09506f8c5a8bc63c0d58bf4c0cf42c74e..1d90cd2b3fc1e2d0157cf1eee4f017e140af2da2 100644

--- a/Source/bindings/scripts/code_generator_v8.py

+++ b/Source/bindings/scripts/code_generator_v8.py

@@ -205,7 +205,8 @@ class CodeGeneratorV8(CodeGeneratorBase):

dictionary):

header_template = self.jinja_env.get_template('dictionary_v8.h')

cpp_template = self.jinja_env.get_template('dictionary_v8.cpp')

- template_context = v8_dictionary.dictionary_context(dictionary)

+ template_context = v8_dictionary.dictionary_context(

+ dictionary, self.interfaces_info)

interface_info = self.interfaces_info[dictionary_name]

include_paths = interface_info.get('dependencies_include_paths')

# Add the include for interface itself