Source/bindings/templates/dictionary_v8.h - Issue 740453004: IDL: Basic dictionary inheritance support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/dictionary_v8.h

Issue 740453004: IDL: Basic dictionary inheritance support (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/templates/dictionary_v8.h

diff --git a/Source/bindings/templates/dictionary_v8.h b/Source/bindings/templates/dictionary_v8.h

index fb751e3ba1de53a27cf1b11e5f263c0054018279..ef6b4f7eef6e1f553f6b49f4123dd1f58dc6def2 100644

--- a/Source/bindings/templates/dictionary_v8.h

+++ b/Source/bindings/templates/dictionary_v8.h

@@ -21,6 +21,7 @@ public:

};

v8::Handle<v8::Value> toV8({{cpp_class}}&, v8::Handle<v8::Object>, v8::Isolate*);

+void toV8Internal({{cpp_class}}&, v8::Handle<v8::Object> dest, v8::Handle<v8::Object> creationContext, v8::Isolate*);

Jens Widell 2014/11/19 06:41:47 We could call this toV8{{cpp_class}}() instead. Th

bashi 2014/11/19 07:35:22 This looks much better:) Done.

template<class CallbackInfo>

inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{cpp_class}}& impl)