Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 740443002: Fix alignment of Code::kConstantPoolOffset. (Closed)

Created:
6 years, 1 month ago by andrew_low
Modified:
6 years, 1 month ago
Reviewers:
Sven Panne, ulan, rmcilroy
CC:
v8-dev, Sven Panne
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Fix alignment of Code::kConstantPoolOffset. This is needed for 64bit alignment sensitive platforms (PowerPC) Exposed bugs with new GC compare and swap changes updating the field. Example failing test: out/ppc64.debug/cctest test-decls/ExistsInPrototype BUG=

Patch Set 1 #

Patch Set 2 : Fix alignment of Code::kConstantPoolOffset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/objects.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
andrew_low
With recent GC changes updating this field with compare and swap, we starting having new ...
6 years, 1 month ago (2014-11-18 15:29:11 UTC) #1
andrew_low
Forgot to add an actual reviewer (doh)
6 years, 1 month ago (2014-11-21 14:33:23 UTC) #3
Sven Panne
Delegating to our constant pool black belts... ;-)
6 years, 1 month ago (2014-11-24 07:11:33 UTC) #5
rmcilroy
On 2014/11/24 07:11:33, Sven Panne wrote: > Delegating to our constant pool black belts... ;-) ...
6 years, 1 month ago (2014-11-24 09:39:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740443002/20001
6 years, 1 month ago (2014-11-24 10:03:12 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-24 10:22:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698