Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 740403002: Revert of Enable loading V8's initial snapshot from external files on Linux. (Closed)

Created:
6 years, 1 month ago by rmcilroy
Modified:
6 years, 1 month ago
Reviewers:
baixo, baixo1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable loading V8's initial snapshot from external files on Linux. (patchset #2 id:20001 of https://codereview.chromium.org/735043002/) Also partial revert of cl r304601 (https://codereview.chromium.org/734163007/) to remove snapshot files form Files.cfg. Reason for revert: Breaking PrintPreviewWebUITest on linux bots. BUG=435167, 421063, 434985 Original issue's description: > Enable loading V8's initial snapshot from external files on Linux. > > BUG=421063, 434985 > > Committed: https://crrev.com/85e17b910590a0da3ed71b5f44e55cba79ea990d > Cr-Commit-Position: refs/heads/master@{#305007} TBR=baixo@google.com,baixo@chromium.org NOTREECHECKS=true NOTRY=true BUG=421063, 434985 Committed: https://crrev.com/69aa92c0b97d845cfe0daf21879055cc354be379 Cr-Commit-Position: refs/heads/master@{#305023}

Patch Set 1 #

Patch Set 2 : Add partial revert of r304601 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/linux/FILES.cfg View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmcilroy
Created Revert of Enable loading V8's initial snapshot from external files on Linux.
6 years, 1 month ago (2014-11-20 16:40:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740403002/40001
6 years, 1 month ago (2014-11-20 16:47:16 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 1 month ago (2014-11-20 16:48:11 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 16:48:51 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69aa92c0b97d845cfe0daf21879055cc354be379
Cr-Commit-Position: refs/heads/master@{#305023}

Powered by Google App Engine
This is Rietveld 408576698