Issue 740383002: Unrevert "Sky: When an iframe element is removed, delete its mojo View."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 740383002: Unrevert "Sky: When an iframe element is removed, delete its mojo View." (Closed)

Created:
6 years, 1 month ago by Matt Perry

Modified:
6 years, 1 month ago

Reviewers:
sky

CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Unrevert "Sky: When an iframe element is removed, delete its mojo View." This reverts commit acec66c735d6a40d3da3e0e9a6ee5f278bdfe043. Scott thinks he fixed the crash. BUG=434555 TBR=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/65b7c3b363628060236016ba1bb2c8b358c3e498

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	sky/engine/core/html/HTMLIFrameElement.cpp	View		3 chunks	+6 lines, -3 lines	0 comments	Download
	M	sky/tests/lowlevel/iframe.sky	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

Matt Perry

6 years, 1 month ago (2014-11-20 16:13:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
65b7c3b363628060236016ba1bb2c8b358c3e498 (presubmit successful).