Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 740363002: Revert of Set camera parameters continuous focus mode on (Closed)

Created:
6 years, 1 month ago by tommi (sloooow) - chröme
Modified:
6 years, 1 month ago
Reviewers:
qinmin, mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, wjia+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Set camera parameters continuous focus mode on (patchset #1 id:1 of https://codereview.chromium.org/737003003/) Reason for revert: Looks like this is causing MANUAL_CanAcquireVgaOnRealWebcam to fail. Original issue's description: > Android Video Capture: Set continuous focus mode on in cam parameters. > > This is, apparently, needed for macro modes, although > autofocus seems to work ok in general. > > BUG=343894 > TEST=Please refer to the bug, basically a gUM() + close QR codes focus test. > > Committed: https://crrev.com/667e79783dd2bbd413b165abfd7fae2bfa3210d5 > Cr-Commit-Position: refs/heads/master@{#304909} TBR=qinmin@chromium.org,mcasas@chromium.org NOTREECHECKS=true NOTRY=true BUG=343894 Committed: https://crrev.com/ee8c7cac097f864b19d69dcabd6782e4d8c793dd Cr-Commit-Position: refs/heads/master@{#305009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M media/base/android/java/src/org/chromium/media/VideoCaptureCamera.java View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tommi (sloooow) - chröme
Created Revert of Set camera parameters continuous focus mode on
6 years, 1 month ago (2014-11-20 14:15:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740363002/1
6 years, 1 month ago (2014-11-20 14:16:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 14:17:15 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 14:17:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee8c7cac097f864b19d69dcabd6782e4d8c793dd
Cr-Commit-Position: refs/heads/master@{#305009}

Powered by Google App Engine
This is Rietveld 408576698