Issue 740323003: Include llvm-symbolizer in chromium_builder_asan Clang builds.

Issue 740323003: Include llvm-symbolizer in chromium_builder_asan Clang builds. (Closed)

Created:
6 years, 1 month ago by Alexander Potapenko

Modified:
6 years, 1 month ago

Reviewers:
inferno

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Include llvm-symbolizer in chromium_builder_asan Clang builds. BUG=430152 TBR=inferno@chromium.org Committed: https://crrev.com/91f1267dbeddfdfdb5ac87de26932219e0c2dcf2 Cr-Commit-Position: refs/heads/master@{#305206}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	build/all.gyp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 8 (3 generated)

Alexander Potapenko

TBR By the way, I think chromium_builder_asan isn't a good name for this target, as ...

6 years, 1 month ago (2014-11-21 12:35:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740323003/1

6 years, 1 month ago (2014-11-21 12:35:57 UTC) #5

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/91f1267dbeddfdfdb5ac87de26932219e0c2dcf2 Cr-Commit-Position: refs/heads/master@{#305206}

6 years, 1 month ago (2014-11-21 13:33:56 UTC) #7

inferno

6 years, 1 month ago (2014-11-21 14:34:30 UTC) #8

Message was sent while issue was closed.

lgtm.

Yes chromium_builder_asan is an old name that is now obsolete given all the
different tools using the same target.