Timestamps in log file names

src/log.cc

Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index 72eb455b2ac3532bdc357aa8a2347ce8f65e71ee..4505449d5206e4637d93535b7781df59d1e22b69 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -31,6 +31,7 @@
 
 #include "log.h"
 #include "platform.h"
+#include "string-stream.h"
 
 namespace v8 { namespace internal {
 
@@ -686,6 +687,37 @@ bool Logger::Setup() {
   if (open_log_file) {
     if (strcmp(FLAG_logfile, "-") == 0) {
       logfile_ = stdout;
+    } else if (strchr(FLAG_logfile, '%') != NULL) {
+      // If there's a '%' in the log file name we have to expand
+      // placeholders.
+      HeapStringAllocator allocator;
+      StringStream stream(&allocator);
+      for (const char* p = FLAG_logfile; *p; p++) {
+        if (*p == '%') {
+          p++;
+          switch (*p) {
+            case '\0':
+              // If there's a % at the end of the string we back up
+              // one character so we can escape the loop properly.
+              p--;
+              break;
+            case 't': {
+              // %t expands to the current time in milliseconds.
+              uint32_t time = static_cast<uint32_t>(OS::TimeCurrentMillis());
+              stream.Add("%u", time);
+              break;
+            }
+            default:
+              // All other %'s expand to themselves.

[Erik Corry, 2008/10/15 08:36:01]

IMHO they should expand to % followed by themselves.

[Christian Plesner Hansen, 2008/10/15 08:46:32]

Sure, I'll change it -- I don't really care.  I did it this way because then %%
expands to %.

+              stream.Put(*p);
+              break;
+          }
+        } else {
+          stream.Put(*p);
+        }
+      }
+      SmartPointer<char> expanded = stream.ToCString();
+      logfile_ = OS::FOpen(*expanded, "w");
     } else {
       logfile_ = OS::FOpen(FLAG_logfile, "w");
     }