Issue 7403: Timestamps in log file names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7403: Timestamps in log file names (Closed)

Created:
12 years, 2 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Added expansion of '%t' in the log file name to the current time.

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -0 lines)			Patch
	M	src/log.cc	View		2 chunks	+32 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/7403/diff/1/2 File src/log.cc (right): http://codereview.chromium.org/7403/diff/1/2#newcode711 Line 711: // All other %'s expand to themselves. ...

12 years, 2 months ago (2008-10-15 08:36:00 UTC) #2

Christian Plesner Hansen

12 years, 2 months ago (2008-10-15 08:46:31 UTC) #3

http://codereview.chromium.org/7403/diff/1/2
File src/log.cc (right):

http://codereview.chromium.org/7403/diff/1/2#newcode711
Line 711: // All other %'s expand to themselves.
Sure, I'll change it -- I don't really care.  I did it this way because then %%
expands to %.

Expand Messages | Collapse Messages