dart/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart - Issue 740273003: Incremental compiler: support optional arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

Issue 740273003: Incremental compiler: support optional arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Add TODO for a follow-up CL. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/pkg/compiler/lib/src/js_backend/backend.dart ('k') | dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart » ('j') | dart/pkg/dart2js_incremental/lib/library_updater.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

diff --git a/dart/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart b/dart/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

index 802887d9b73b5bb69d124378c73a37b1a6fa380f..37cc77abe18b07f0ef1714f7a8a4ba7aed97a295 100644

--- a/dart/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

+++ b/dart/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

@@ -363,7 +363,11 @@ class ContainerBuilder extends CodeEmitterHelper {

member.isAccessor;

String tearOffName;

- final bool canBeReflected = backend.isAccessibleByReflection(member);

+ final bool canBeReflected = backend.isAccessibleByReflection(member) ||

+ // During incremental compilation, we have to assume that reflection

+ // *might* get enabled.

+ compiler.hasIncrementalSupport;

if (isNotApplyTarget) {

canTearOff = false;