scripts/slave/recipe_modules/platform/api.py - Issue 740263003: Report the HOST_BITS as 64 if the kernel is 32-bit but the CPU supports 64-bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/platform/api.py

Issue 740263003: Report the HOST_BITS as 64 if the kernel is 32-bit but the CPU supports 64-bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/platform/api.py

diff --git a/scripts/slave/recipe_modules/platform/api.py b/scripts/slave/recipe_modules/platform/api.py

index f971208422c122a0ca236b6c44bf32cff4601717..7d078bcb91b8e4829fbd96c7474e094f8228b548 100644

--- a/scripts/slave/recipe_modules/platform/api.py

+++ b/scripts/slave/recipe_modules/platform/api.py

@@ -53,6 +53,12 @@ class PlatformApi(recipe_api.RecipeApi):

self._bits == 64 and

platform.architecture()[0] == '32bit'):

self._bits = 32

+ # On Mac, the inverse of the above is true: the kernel is 32-bit but the

+ # CPU and userspace both are capable of running 64-bit programs.

+ elif (self._name == 'mac' and

+ self._bits == 32 and

+ platform.architecture()[0] == '64bit'):

+ self._bits = 64

@property

@recipe_api.non_step

« no previous file with comments | « no previous file | no next file » | no next file with comments »