Issue 740133002: Updates the shelf reference before handling display metrics change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 740133002: Updates the shelf reference before handling display metrics change. (Closed)

Created:
6 years, 1 month ago by Jun Mukai

Modified:
6 years, 1 month ago

Reviewers:
stevenjb

CC:
chromium-reviews, kalyank, sadrul

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Updates the shelf reference before handling display metrics change. Sometimes OnDisplayMetricsChanged() may be called before shelf_ is set properly. BUG=389171 R=stevenjb@chromium.org TEST=manually Committed: https://crrev.com/aa1f1a0e41ce8e9e6e40bbd28d1b80de68431553 Cr-Commit-Position: refs/heads/master@{#305063}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	ash/system/web_notification/ash_popup_alignment_delegate.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740133002/1

6 years, 1 month ago (2014-11-20 18:43:37 UTC) #4

commit-bot: I haz the power

6 years, 1 month ago (2014-11-20 19:40:06 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/aa1f1a0e41ce8e9e6e40bbd28d1b80de68431553
Cr-Commit-Position: refs/heads/master@{#305063}