Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 740093002: Remove the menu button from the menu popup. (Closed)

Created:
6 years, 1 month ago by Ted C
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove the menu button from the menu popup. This is a minimum change to allow easy cherrypicking to m40. Much more code needs to be removed to completely rid the menu of this. BUG=434608 Committed: https://crrev.com/417188dbb7e085ea64045a5d1059978b5c388f6d Cr-Commit-Position: refs/heads/master@{#304954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ted C
PTAL
6 years, 1 month ago (2014-11-20 00:12:44 UTC) #2
aurimas (slooooooooow)
lgtm
6 years, 1 month ago (2014-11-20 00:16:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740093002/1
6 years, 1 month ago (2014-11-20 00:29:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 01:27:48 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 01:28:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/417188dbb7e085ea64045a5d1059978b5c388f6d
Cr-Commit-Position: refs/heads/master@{#304954}

Powered by Google App Engine
This is Rietveld 408576698