Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 74003003: spellcheck-editable-on-focus.html does not tests all elements (Closed)

Created:
7 years, 1 month ago by grzegorz
Modified:
7 years, 1 month ago
Reviewers:
tony, groby-ooo-7-16
CC:
blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

spellcheck-editable-on-focus.html does not test all elements This tests misspellings on editable elements (div, text area, input). However, after r161840 only first one is being tested. Additionally, rename setFocusOnEditableElements() to triggerSpellingForEditables() to better describe what it does. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162124

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M LayoutTests/editing/spelling/spellcheck-editable-on-focus.html View 3 chunks +5 lines, -7 lines 0 comments Download
M LayoutTests/editing/spelling/spellcheck-editable-on-focus-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
grzegorz
I introduced it by mistake at https://codereview.chromium.org/25507002/. Sorry for that :/
7 years, 1 month ago (2013-11-15 13:29:06 UTC) #1
tony
LGTM
7 years, 1 month ago (2013-11-15 17:01:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/74003003/1
7 years, 1 month ago (2013-11-15 17:02:36 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-15 18:22:03 UTC) #4
Message was sent while issue was closed.
Change committed as 162124

Powered by Google App Engine
This is Rietveld 408576698