chrome/browser/ui/views/find_bar_host.cc - Issue 739993002: MacViews: Fix build errors related to NativeWebKeyboardEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/find_bar_host.cc

Issue 739993002: MacViews: Fix build errors related to NativeWebKeyboardEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/dropdown_bar_host_aura.cc ('k') | content/browser/renderer_host/native_web_keyboard_event_aura.cc » ('j') | content/browser/renderer_host/web_input_event_aura.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/find_bar_host.cc

diff --git a/chrome/browser/ui/views/find_bar_host.cc b/chrome/browser/ui/views/find_bar_host.cc

index 36604228e7fc3750f0d461d2629c898f623d2907..97a89ea7ff0673a57716214796165b3c80873092 100644

--- a/chrome/browser/ui/views/find_bar_host.cc

+++ b/chrome/browser/ui/views/find_bar_host.cc

@@ -70,7 +70,7 @@ bool FindBarHost::MaybeForwardKeyEventToWebpage(

// Make sure we don't have a text field element interfering with keyboard

// input. Otherwise Up and Down arrow key strokes get eaten. "Nom Nom Nom".

render_view_host->ClearFocusedElement();

- NativeWebKeyboardEvent event = GetKeyboardEvent(contents, key_event);

sadrul 2014/11/21 19:33:42 Looks like you can remove DropdownBarHost::GetKeyb

Andre 2014/11/22 00:09:58 Yes, I removed it.

+ NativeWebKeyboardEvent event(key_event);

render_view_host->ForwardKeyboardEvent(event);

return true;

}