MacViews: Fix build errors related to NativeWebKeyboardEvent

MacViews: Fix build errors related to NativeWebKeyboardEvent

This fixes 2 build errors for MacViews:
1. Compile error in AutofillDialogViews::HandleKeyEvent.
2. Missing symbol of DropdownBarHost::GetKeyboardEvent.

Added a NativeWebKeyboardEvent constructor that takes a ui::KeyEvent,
which is convenient for these callers.

BUG=425229
Committed: https://crrev.com/02f3a9f5b2b31af2dbc8c5bc8695dc5f05be1f6d
Cr-Commit-Position: refs/heads/master@{#305583}

[Andre, 2014-11-20 00:18:48]

Patchset #1 (id:1) has been deleted

[Andre, 2014-11-20 01:01:43]

andresantoso@chromium.org changed reviewers:
+ mac-views-reviews@chromium.org, sadrul@chromium.org

[Andre, 2014-11-20 01:01:44]

Sadrul, PTAL.

https://codereview.chromium.org/739993002/diff/20001/content/renderer/render_...
File content/renderer/render_view_browsertest.cc (right):

https://codereview.chromium.org/739993002/diff/20001/content/renderer/render_...
content/renderer/render_view_browsertest.cc:195: #endif
Should I delete these USE_AURA guards?

[Andre, 2014-11-21 17:39:48]

andresantoso@chromium.org changed reviewers:
+ avi@chromium.org, sky@chromium.org

[Andre, 2014-11-21 17:39:48]

avi@, PTAL for content.
sky@, PTAL for views.

[sky, 2014-11-21 19:02:22]

LGTM

[sadrul, 2014-11-21 19:33:42]

https://codereview.chromium.org/739993002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/find_bar_host.cc (left):

https://codereview.chromium.org/739993002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/find_bar_host.cc:73: NativeWebKeyboardEvent event =
GetKeyboardEvent(contents, key_event);
Looks like you can remove DropdownBarHost::GetKeyboardEvent() altogether?

https://codereview.chromium.org/739993002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/web_input_event_aura.h (right):

https://codereview.chromium.org/739993002/diff/20001/content/browser/renderer...
content/browser/renderer_host/web_input_event_aura.h:32: const ui::KeyEvent*
event);
Not for this CL ... but should this (and the rest) be const& events instead?

https://codereview.chromium.org/739993002/diff/20001/content/public/browser/n...
File content/public/browser/native_web_keyboard_event.h (right):

https://codereview.chromium.org/739993002/diff/20001/content/public/browser/n...
content/public/browser/native_web_keyboard_event.h:29: explicit
NativeWebKeyboardEvent(const ui::KeyEvent& key_event);
Should this have some sort of #ifdef guard? (I don't think we use ui::KeyEvent
on android, for example?)

https://codereview.chromium.org/739993002/diff/20001/content/renderer/render_...
File content/renderer/render_view_browsertest.cc (right):

https://codereview.chromium.org/739993002/diff/20001/content/renderer/render_...
content/renderer/render_view_browsertest.cc:195: #endif
On 2014/11/20 01:01:43, Andre wrote:
> Should I delete these USE_AURA guards?

Yeah, I think you can remove the non-USE_AURA code for OS_WIN

[Avi (use Gerrit), 2014-11-21 20:16:19]

lgtm

I don't have anything to say past what sadrul said. It would be really nice to
move to const& rather than const*. That gets so awkward at the boundary.

[Andre, 2014-11-22 00:09:12]

On 2014/11/21 20:16:19, Avi wrote:
> lgtm
> 
> I don't have anything to say past what sadrul said. It would be really nice to
> move to const& rather than const*. That gets so awkward at the boundary.

I made a patch to do this conversion, https://crrev.com/740653006/.

[Andre, 2014-11-22 00:09:59]

https://codereview.chromium.org/739993002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/find_bar_host.cc (left):

https://codereview.chromium.org/739993002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/find_bar_host.cc:73: NativeWebKeyboardEvent event =
GetKeyboardEvent(contents, key_event);
On 2014/11/21 19:33:42, sadrul wrote:
> Looks like you can remove DropdownBarHost::GetKeyboardEvent() altogether?

Yes, I removed it.

https://codereview.chromium.org/739993002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/web_input_event_aura.h (right):

https://codereview.chromium.org/739993002/diff/20001/content/browser/renderer...
content/browser/renderer_host/web_input_event_aura.h:32: const ui::KeyEvent*
event);
On 2014/11/21 19:33:42, sadrul wrote:
> Not for this CL ... but should this (and the rest) be const& events instead?

See https://codereview.chromium.org/740653006/

https://codereview.chromium.org/739993002/diff/20001/content/public/browser/n...
File content/public/browser/native_web_keyboard_event.h (right):

https://codereview.chromium.org/739993002/diff/20001/content/public/browser/n...
content/public/browser/native_web_keyboard_event.h:29: explicit
NativeWebKeyboardEvent(const ui::KeyEvent& key_event);
On 2014/11/21 19:33:42, sadrul wrote:
> Should this have some sort of #ifdef guard? (I don't think we use ui::KeyEvent
> on android, for example?)

Done.
Now guarded inside !ANDROID.
And looks like the OSX one is unused, so I deleted it.

https://codereview.chromium.org/739993002/diff/20001/content/renderer/render_...
File content/renderer/render_view_browsertest.cc (right):

https://codereview.chromium.org/739993002/diff/20001/content/renderer/render_...
content/renderer/render_view_browsertest.cc:195: #endif
On 2014/11/21 19:33:42, sadrul wrote:
> On 2014/11/20 01:01:43, Andre wrote:
> > Should I delete these USE_AURA guards?
> 
> Yeah, I think you can remove the non-USE_AURA code for OS_WIN

Done.

[Andre, 2014-11-22 01:59:50]

andresantoso@chromium.org changed reviewers:
- mac-views-reviews@chromium.org

[sadrul, 2014-11-24 06:24:33]

LGTM (I suggest landing https://codereview.chromium.org/740653006/ first, and
then rebasing this on top of it before landing)

https://codereview.chromium.org/739993002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/native_web_keyboard_event_aura.cc (right):

https://codereview.chromium.org/739993002/diff/40001/content/browser/renderer...
content/browser/renderer_host/native_web_keyboard_event_aura.cc:19: : NULL;
You can do:
  return event ? ui::Event::Clone(*event) : nullptr;
instead.

[Andre, 2014-11-25 03:26:36]

Patchset #3 (id:60001) has been deleted

[Andre, 2014-11-25 03:26:57]

https://codereview.chromium.org/739993002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/native_web_keyboard_event_aura.cc (right):

https://codereview.chromium.org/739993002/diff/40001/content/browser/renderer...
content/browser/renderer_host/native_web_keyboard_event_aura.cc:19: : NULL;
On 2014/11/24 06:24:33, sadrul wrote:
> You can do:
>   return event ? ui::Event::Clone(*event) : nullptr;
> instead.

Done.

[Andre, 2014-11-25 03:27:06]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2014-11-25 03:27:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/739993002/80001

[commit-bot: I haz the power, 2014-11-25 05:36:13]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2014-11-25 05:38:19]

Patchset 3 (id:??) landed as
https://crrev.com/02f3a9f5b2b31af2dbc8c5bc8695dc5f05be1f6d
Cr-Commit-Position: refs/heads/master@{#305583}