net/base/net_util_linux.h - Issue 739983005: Determine connection type in NetworkChangeNotifierLinux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/net_util_linux.h

Issue 739983005: Determine connection type in NetworkChangeNotifierLinux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from patch set 5 Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/net_util_linux.h

diff --git a/net/base/net_util_linux.h b/net/base/net_util_linux.h

index 340c3802eea080878a82db44a6b989a6c329971b..3937716834eb64006ec18443dc072dc1d7e04824 100644

--- a/net/base/net_util_linux.h

+++ b/net/base/net_util_linux.h

@@ -8,6 +8,8 @@

// This file is only used to expose some of the internals

// of net_util_linux.cc to tests.

+#include <string>

pauljensen 2015/01/27 20:25:17 unused?

derekjchow1 2015/01/27 21:50:32 Done.

#include "base/containers/hash_tables.h"

#include "net/base/address_tracker_linux.h"

#include "net/base/net_util.h"

@@ -15,8 +17,7 @@

namespace net {

namespace internal {

-typedef char* (*GetInterfaceNameFunction)(unsigned int interface_index,

- char* ifname);

+typedef char* (*GetInterfaceNameFunction)(int interface_index, char* ifname);

NET_EXPORT bool GetNetworkListImpl(

NetworkInterfaceList* networks,

« net/base/address_tracker_linux.cc ('K') | « net/base/address_tracker_linux_unittest.cc ('k') | net/base/net_util_linux.cc » ('j') | net/base/net_util_linux.cc » ('J')