Determine connection type in NetworkChangeNotifierLinux.

net/base/net_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/net_util.h"
 
 #include <string.h>
 
 #include <ostream>
 
@@ skipping 859 matching lines @@
       EXPECT_NE(WIFI_PHY_LAYER_PROTOCOL_NONE, GetWifiPHYLayerProtocol());
     }
 #elif !defined(OS_ANDROID)
     char name[IF_NAMESIZE];
     EXPECT_TRUE(if_indextoname(it->interface_index, name));
     EXPECT_STREQ(it->name.c_str(), name);
 #endif
   }
 }
 
+TEST(NetUtilTest, ConnectionTypeFromInterfaceList) {

[pauljensen, 2015/01/15 15:05:10]

please move to network_change_notifier_unittest.cc

[derekjchow1, 2015/01/15 20:32:51]

Done.

+  NetworkInterfaceList list;
+
+  // Test empty list.
+  EXPECT_EQ(net::ConnectionTypeFromInterfaceList(list),
+            NetworkChangeNotifier::CONNECTION_NONE);
+
+  NetworkInterface interface;

[pauljensen, 2015/01/15 15:05:10]

please move inside the loop

[derekjchow1, 2015/01/15 20:32:51]

Done.

+  for (int i = NetworkChangeNotifier::CONNECTION_UNKNOWN;
+       i < NetworkChangeNotifier::CONNECTION_LAST; i++) {

[pauljensen, 2015/01/15 15:05:10]

< should be <=

[derekjchow1, 2015/01/15 20:32:51]

Done.

+    // Check individual types.
+    list.clear();
+    interface.type = static_cast<NetworkChangeNotifier::ConnectionType>(i);
+    list.push_back(interface);
+    EXPECT_EQ(net::ConnectionTypeFromInterfaceList(list), i);
+    // Check two types.
+    for (int j = NetworkChangeNotifier::CONNECTION_UNKNOWN;
+         j < NetworkChangeNotifier::CONNECTION_LAST; j++) {

[pauljensen, 2015/01/15 15:05:10]

< should be <=

[derekjchow1, 2015/01/15 20:32:51]

Done.

+      list.clear();
+      interface.type = static_cast<NetworkChangeNotifier::ConnectionType>(i);
+      list.push_back(interface);
+      interface.type = static_cast<NetworkChangeNotifier::ConnectionType>(j);
+      list.push_back(interface);
+      EXPECT_EQ(net::ConnectionTypeFromInterfaceList(list),
+                i == j ? i : NetworkChangeNotifier::CONNECTION_UNKNOWN);
+    }
+  }
+}
+
 static const char ifname_em1[] = "em1";
 #if defined(OS_WIN)
 static const char ifname_vm[] = "VMnet";
 #else
 static const char ifname_vm[] = "vmnet";
 #endif  // OS_WIN
 
 static const unsigned char kIPv6LocalAddr[] = {
   0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1};
 
@@ skipping 599 matching lines @@
 TEST_P(NetUtilNonUniqueNameTest, IsHostnameNonUnique) {
   const NonUniqueNameTestData& test_data = GetParam();
 
   EXPECT_EQ(test_data.is_unique, IsUnique(test_data.hostname));
 }
 
 INSTANTIATE_TEST_CASE_P(, NetUtilNonUniqueNameTest,
                         testing::ValuesIn(kNonUniqueNameTestData));
 
 }  // namespace net