Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Side by Side Diff: net/base/net_util_linux.cc

Issue 739983005: Determine connection type in NetworkChangeNotifierLinux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments in patchset 9 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/base/net_util_linux.h ('k') | net/base/net_util_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/net_util_linux.h" 5 #include "net/base/net_util_linux.h"
6 6
7 #include <net/if.h> 7 #include <linux/ethtool.h>
8 #include <netinet/in.h> 8 #include <linux/if.h>
9 #include <linux/sockios.h>
10 #include <linux/wireless.h>
9 #include <set> 11 #include <set>
12 #include <sys/ioctl.h>
10 #include <sys/types.h> 13 #include <sys/types.h>
11 14
12 #include "base/files/file_path.h" 15 #include "base/files/file_path.h"
16 #include "base/files/scoped_file.h"
13 #include "base/logging.h" 17 #include "base/logging.h"
14 #include "base/memory/scoped_ptr.h" 18 #include "base/memory/scoped_ptr.h"
15 #include "base/strings/string_number_conversions.h" 19 #include "base/strings/string_number_conversions.h"
16 #include "base/strings/string_tokenizer.h" 20 #include "base/strings/string_tokenizer.h"
17 #include "base/strings/string_util.h" 21 #include "base/strings/string_util.h"
18 #include "base/threading/thread_restrictions.h" 22 #include "base/threading/thread_restrictions.h"
19 #include "net/base/address_tracker_linux.h" 23 #include "net/base/address_tracker_linux.h"
20 #include "net/base/escape.h" 24 #include "net/base/escape.h"
21 #include "net/base/ip_endpoint.h" 25 #include "net/base/ip_endpoint.h"
22 #include "net/base/net_errors.h" 26 #include "net/base/net_errors.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 namespace internal { 66 namespace internal {
63 67
64 inline const unsigned char* GetIPAddressData(const IPAddressNumber& ip) { 68 inline const unsigned char* GetIPAddressData(const IPAddressNumber& ip) {
65 #if defined(OS_ANDROID) 69 #if defined(OS_ANDROID)
66 return ip.begin(); 70 return ip.begin();
67 #else 71 #else
68 return ip.data(); 72 return ip.data();
69 #endif 73 #endif
70 } 74 }
71 75
76 // Gets the connection type for interface |ifname| by checking for wireless
77 // or ethtool extensions.
78 NetworkChangeNotifier::ConnectionType GetInterfaceConnectionType(
79 const std::string& ifname) {
80 base::ScopedFD s(socket(AF_INET, SOCK_STREAM, 0));
81 if (!s.is_valid())
82 return NetworkChangeNotifier::CONNECTION_UNKNOWN;
83
84 // Test wireless extensions for CONNECTION_WIFI
85 struct iwreq pwrq = {};
86 strncpy(pwrq.ifr_name, ifname.c_str(), IFNAMSIZ - 1);
87 if (ioctl(s.get(), SIOCGIWNAME, &pwrq) != -1)
88 return NetworkChangeNotifier::CONNECTION_WIFI;
89
90 // Test ethtool for CONNECTION_ETHERNET
91 struct ethtool_cmd ecmd = {.cmd = ETHTOOL_GSET};
92 struct ifreq ifr = {.ifr_data = &ecmd};
93 strncpy(ifr.ifr_name, ifname.c_str(), IFNAMSIZ - 1);
94 if (ioctl(s.get(), SIOCETHTOOL, &ifr) != -1)
95 return NetworkChangeNotifier::CONNECTION_ETHERNET;
96
97 return NetworkChangeNotifier::CONNECTION_UNKNOWN;
98 }
99
72 bool GetNetworkListImpl( 100 bool GetNetworkListImpl(
73 NetworkInterfaceList* networks, 101 NetworkInterfaceList* networks,
74 int policy, 102 int policy,
75 const base::hash_set<int>& online_links, 103 const base::hash_set<int>& online_links,
76 const internal::AddressTrackerLinux::AddressMap& address_map, 104 const internal::AddressTrackerLinux::AddressMap& address_map,
77 GetInterfaceNameFunction get_interface_name) { 105 GetInterfaceNameFunction get_interface_name) {
78 std::map<int, std::string> ifnames; 106 std::map<int, std::string> ifnames;
79 107
80 for (internal::AddressTrackerLinux::AddressMap::const_iterator it = 108 for (internal::AddressTrackerLinux::AddressMap::const_iterator it =
81 address_map.begin(); 109 address_map.begin();
(...skipping 23 matching lines...) Expand all
105 if (!TryConvertNativeToNetIPAttributes(it->second.ifa_flags, 133 if (!TryConvertNativeToNetIPAttributes(it->second.ifa_flags,
106 &ip_attributes)) 134 &ip_attributes))
107 continue; 135 continue;
108 } 136 }
109 137
110 // Find the name of this link. 138 // Find the name of this link.
111 std::map<int, std::string>::const_iterator itname = 139 std::map<int, std::string>::const_iterator itname =
112 ifnames.find(it->second.ifa_index); 140 ifnames.find(it->second.ifa_index);
113 std::string ifname; 141 std::string ifname;
114 if (itname == ifnames.end()) { 142 if (itname == ifnames.end()) {
115 char buffer[IF_NAMESIZE] = {0}; 143 char buffer[IFNAMSIZ] = {0};
116 if (get_interface_name(it->second.ifa_index, buffer)) { 144 ifname.assign(get_interface_name(it->second.ifa_index, buffer));
pauljensen 2015/01/29 14:24:57 You removed the write to ifnames; please restore.
derekjchow1 2015/01/29 18:14:35 Done.
117 ifname = ifnames[it->second.ifa_index] = buffer; 145 // Ignore addresses whose interface name can't be retrieved.
118 } else { 146 if (ifname.empty())
119 // Ignore addresses whose interface name can't be retrieved.
120 continue; 147 continue;
121 }
122 } else { 148 } else {
123 ifname = itname->second; 149 ifname = itname->second;
124 } 150 }
125 151
126 // Based on the interface name and policy, determine whether we 152 // Based on the interface name and policy, determine whether we
127 // should ignore it. 153 // should ignore it.
128 if (ShouldIgnoreInterface(ifname, policy)) 154 if (ShouldIgnoreInterface(ifname, policy))
129 continue; 155 continue;
130 156
157 NetworkChangeNotifier::ConnectionType type =
158 GetInterfaceConnectionType(ifname);
159
131 networks->push_back( 160 networks->push_back(
132 NetworkInterface(ifname, ifname, it->second.ifa_index, 161 NetworkInterface(ifname, ifname, it->second.ifa_index, type, it->first,
133 NetworkChangeNotifier::CONNECTION_UNKNOWN, it->first,
134 it->second.ifa_prefixlen, ip_attributes)); 162 it->second.ifa_prefixlen, ip_attributes));
135 } 163 }
136 164
137 return true; 165 return true;
138 } 166 }
139 167
140 } // namespace internal 168 } // namespace internal
141 169
142 bool GetNetworkList(NetworkInterfaceList* networks, int policy) { 170 bool GetNetworkList(NetworkInterfaceList* networks, int policy) {
143 if (networks == NULL) 171 if (networks == NULL)
144 return false; 172 return false;
145 173
146 internal::AddressTrackerLinux tracker; 174 internal::AddressTrackerLinux tracker;
147 tracker.Init(); 175 tracker.Init();
148 176
149 return internal::GetNetworkListImpl(networks, policy, 177 return internal::GetNetworkListImpl(
150 tracker.GetOnlineLinks(), 178 networks, policy, tracker.GetOnlineLinks(), tracker.GetAddressMap(),
151 tracker.GetAddressMap(), &if_indextoname); 179 &internal::AddressTrackerLinux::GetInterfaceName);
152 } 180 }
153 181
154 } // namespace net 182 } // namespace net
OLDNEW
« no previous file with comments | « net/base/net_util_linux.h ('k') | net/base/net_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698