Chromium Code Reviews

Issue 739983004: Allow running adb_gdb in a subdirectory of src/. (Closed)

Created:
6 years, 1 month ago by Bernhard Bauer
Modified:
6 years ago
Reviewers:
pasko, Fabrice (no longer in Chrome)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow running adb_gdb in a subdirectory of src/. Committed: https://crrev.com/da8f334aff6b9bab71cee4f9df7db0c8adb40312 Cr-Commit-Position: refs/heads/master@{#305410}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+1 line, -1 line)
M build/android/adb_gdb View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 14 (5 generated)
Bernhard Bauer
Please review.
6 years, 1 month ago (2014-11-21 13:58:58 UTC) #2
Fabrice (no longer in Chrome)
LGTM thanks!
6 years, 1 month ago (2014-11-21 14:22:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739983004/1
6 years, 1 month ago (2014-11-21 14:34:27 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-21 14:34:28 UTC) #7
Fabrice (no longer in Chrome)
+pasko who is an actual committer for rubber stamping.
6 years, 1 month ago (2014-11-21 15:35:03 UTC) #9
pasko
lgtm
6 years, 1 month ago (2014-11-21 16:02:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739983004/1
6 years ago (2014-11-24 09:39:53 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-24 10:20:55 UTC) #13
commit-bot: I haz the power
6 years ago (2014-11-24 10:21:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da8f334aff6b9bab71cee4f9df7db0c8adb40312
Cr-Commit-Position: refs/heads/master@{#305410}

Powered by Google App Engine