Make Notification override hasPendingActivity() to prolong its lifetime while async op is running

Make Notification override hasPendingActivity() to prolong its lifetime while async op is running

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162196

[abarth-chromium, 2013-11-15 16:02:54]

LGTM.  Thank you, this looks much better.

https://codereview.chromium.org/73993003/diff/30001/Source/modules/notificati...
File Source/modules/notifications/Notification.cpp (right):

https://codereview.chromium.org/73993003/diff/30001/Source/modules/notificati...
Source/modules/notifications/Notification.cpp:178: m_state = Closed;
Do we need to tell the m_asyncRunner to stop, or does that happen automatically
somehow?

[tyoshino (SeeGerritForStatus), 2013-11-18 10:53:12]

https://codereview.chromium.org/73993003/diff/30001/Source/modules/notificati...
File Source/modules/notifications/Notification.cpp (right):

https://codereview.chromium.org/73993003/diff/30001/Source/modules/notificati...
Source/modules/notifications/Notification.cpp:178: m_state = Closed;
On 2013/11/15 16:02:55, abarth wrote:
> Do we need to tell the m_asyncRunner to stop, or does that happen
automatically
> somehow?

Good catch. Since
- if m_state is set to non Idle, show() does nothing
- when this object dies, m_asyncRunner is cleared so, there's not worry about
UAF
it's fine. But to avoid such a useless invocation, added code to call stop() on
it.

[commit-bot: I haz the power, 2013-11-18 10:54:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/73993003/100001

[commit-bot: I haz the power, 2013-11-18 12:32:36]

Change committed as 162196