Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 739823002: X87: Re-land r25392 Use a stub in crankshaft for grow store arrays. (Closed)

Created:
6 years, 1 month ago by chunyang.dai
Modified:
6 years, 1 month ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

X87: Re-land r25392 Use a stub in crankshaft for grow store arrays. port 47f55baeaff0d59366772db95b6c0328a216f611 (r25397) original commit message: Re-land r25392 Use a stub in crankshaft for grow store arrays. Code was vulnerable to different evaluation order in Clang. BUG= Committed: https://chromium.googlesource.com/v8/v8/+/dc73eef412f58930b545897d44ea378503fc4fe1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/x87/interface-descriptors-x87.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
chunyang.dai
WL. PTAL. thanks
6 years, 1 month ago (2014-11-19 05:11:14 UTC) #2
Weiliang
lgtm
6 years, 1 month ago (2014-11-19 07:58:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739823002/1
6 years, 1 month ago (2014-11-19 09:00:43 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 09:28:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698