Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 739813003: Revert of Changing setTimeout to not clamp delays to 1ms (Closed)

Created:
6 years, 1 month ago by alex clarke (OOO till 29th)
Modified:
6 years, 1 month ago
CC:
blink-reviews, eseidel
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Changing setTimeout to not clamp delays to 1ms minimum, since a 1ms clamp is not in the spec. (patchset #21 id:390001 of https://codereview.chromium.org/467153003/) Reason for revert: It broke setInterval(0) see https://code.google.com/p/chromium/issues/detail?id=434601 We need to decide what to do with setInterval(0) I can see some legitimate uses of that (e.g. implementing a scheduler in JS) but I can also see a lot of ways existing code may break. Perhaps we still need the clamp for setInterval :( Original issue's description: > Changing setTimeout to not clamp delays to 1ms minimum, since a 1ms clamp is not in the spec. > > ATTN Sheriffs: There is good probability that that this patch may have unintended side effects. For example there may be some JS tests that use setTimeout(...0) and hope that layout will occur. With this patch that's much less likely to be the case and is actually a bug in the test. I tried to fix some of those here https://codereview.chromium.org/644093003/ > > Another possibility is that something using setInterval(... 0) may suddenly show a perf regression due to running much more frequently. > > BUG=402694 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185372 TBR=jochen@chromium.org,alexclarke@google.com,eseidel@chromium.org,jamesr@chromium.org,skyostil@chromium.org NOTREECHECKS=true NOTRY=true BUG=402694 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/frame/DOMTimer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
alex clarke (OOO till 29th)
Created Revert of Changing setTimeout to not clamp delays to 1ms minimum, since a 1ms ...
6 years, 1 month ago (2014-11-19 12:18:26 UTC) #1
Sami
lgtm.
6 years, 1 month ago (2014-11-19 13:50:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739813003/1
6 years, 1 month ago (2014-11-19 13:51:09 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 13:52:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185589

Powered by Google App Engine
This is Rietveld 408576698