DescriptionRevert of Changing setTimeout to not clamp delays to 1ms minimum, since a 1ms clamp is not in the spec. (patchset #21 id:390001 of https://codereview.chromium.org/467153003/)
Reason for revert:
It broke setInterval(0) see https://code.google.com/p/chromium/issues/detail?id=434601
We need to decide what to do with setInterval(0) I can see some legitimate uses of that (e.g. implementing a scheduler in JS) but I can also see a lot of ways existing code may break.
Perhaps we still need the clamp for setInterval :(
Original issue's description:
> Changing setTimeout to not clamp delays to 1ms minimum, since a 1ms clamp is not in the spec.
>
> ATTN Sheriffs: There is good probability that that this patch may have unintended side effects. For example there may be some JS tests that use setTimeout(...0) and hope that layout will occur. With this patch that's much less likely to be the case and is actually a bug in the test. I tried to fix some of those here https://codereview.chromium.org/644093003/
>
> Another possibility is that something using setInterval(... 0) may suddenly show a perf regression due to running much more frequently.
>
> BUG=402694
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185372
TBR=jochen@chromium.org,alexclarke@google.com,eseidel@chromium.org,jamesr@chromium.org,skyostil@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=402694
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185589
Patch Set 1 #
Created: 6 years, 1 month ago
(Patch set is too large to download)
Messages
Total messages: 10 (6 generated)
|