Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Issue 739813002: Leave the '://' grey in android's page info dialog. (Closed)

Created:
6 years, 1 month ago by benwells
Modified:
6 years, 1 month ago
Reviewers:
Ted C
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2214
Project:
chromium
Visibility:
Public.

Description

Leave the '://' grey in android's page info dialog. Previously it was colored black with the origin. TBR=tedchoc@chromium.org BUG=430771 Review URL: https://codereview.chromium.org/706113006 Cr-Commit-Position: refs/heads/master@{#303976} (cherry picked from commit bd0521db1aa40c0f72177c171896069c71ea2327) Committed: https://chromium.googlesource.com/chromium/src/+/eb0ae28b5613302ee704742de58952a4ea3d56a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java View 2 chunks +20 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
benwells
6 years, 1 month ago (2014-11-19 04:59:57 UTC) #1
benwells
6 years, 1 month ago (2014-11-19 05:02:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb0ae28b5613302ee704742de58952a4ea3d56a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698