Redesign UI for accurateness property of file

plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ChromiumRemoteTab.java

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.debug.ui.launcher;
 
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 
 import org.chromium.debug.core.ChromiumDebugPlugin;
 import org.chromium.debug.core.ChromiumSourceDirector;
 import org.chromium.debug.core.SourceNameMapperContainer;
 import org.chromium.debug.core.model.BreakpointSynchronizer.Direction;
 import org.chromium.debug.core.model.LaunchParams;
-import org.chromium.debug.core.model.LaunchParams.LookupAccurateness;
+import org.chromium.debug.core.model.LaunchParams.LookupMode;
 import org.chromium.debug.core.model.LaunchParams.ValueConverter;
 import org.eclipse.core.runtime.CoreException;
 import org.eclipse.debug.core.DebugPlugin;
 import org.eclipse.debug.core.ILaunchConfiguration;
 import org.eclipse.debug.core.ILaunchConfigurationWorkingCopy;
 import org.eclipse.debug.core.ILaunchManager;
 import org.eclipse.debug.core.model.ISourceLocator;
 import org.eclipse.debug.core.sourcelookup.IPersistableSourceLocator2;
 import org.eclipse.debug.core.sourcelookup.ISourceContainer;
 import org.eclipse.debug.core.sourcelookup.ISourceLookupDirector;
@@ skipping 32 matching lines @@
    // However, recommended range is [1024, 32767].
   private static final int minimumPortValue = 0;
   private static final int maximumPortValue = 65535;
 
   private final SourceContainerChecker sourceContainerChecker = new SourceContainerChecker();
   private final Params params;
   private TabElements tabElements = null;
 
   public static class Params {
     private final HostChecker hostChecker;
-    private final LookupAccurateness newConfigLookupAccurateness;
+    private final LookupMode newConfigLookupMode;
     private final String scriptNameDescription;
 
-    public Params(HostChecker hostChecker,
-        LookupAccurateness newConfigLookupAccurateness,
+    public Params(HostChecker hostChecker, LookupMode newConfigLookupMode,
         String scriptNameDescription) {
       this.hostChecker = hostChecker;
-      this.newConfigLookupAccurateness = newConfigLookupAccurateness;
+      this.newConfigLookupMode = newConfigLookupMode;
       this.scriptNameDescription = scriptNameDescription;
     }
 
     HostChecker getHostChecker() {
       return hostChecker;
     }
 
-    LookupAccurateness getNewConfigLookupAccurateness() {
-      return newConfigLookupAccurateness;
+    LookupMode getNewConfigLookupMode() {
+      return newConfigLookupMode;
     }
 
     String getScriptNameDescription() {
       return scriptNameDescription;
     }
 
     public static final Params CHROME = new Params(HostChecker.LOCAL_ONLY,
-        LaunchParams.LookupAccurateness.INACCURATE, "URL");
+        LaunchParams.LookupMode.AUTO_DETECT, "URL");
 
     public static final Params STANDALONE = new Params(null,
-        LaunchParams.LookupAccurateness.INACCURATE, "plain file path");
+        LaunchParams.LookupMode.AUTO_DETECT, "plain file path");
 
     public static final Params WIP = new Params(HostChecker.LOCAL_ONLY,
-        LaunchParams.LookupAccurateness.ACCURATE, "URL");
+        LaunchParams.LookupMode.EXACT_MATCH, "URL");
   }
 
   /**
    * Possibly checks host property in config.
    */
   public static abstract class HostChecker {
     public abstract String getWarning(ILaunchConfiguration config) throws CoreException;
 
     public static HostChecker LOCAL_ONLY = new HostChecker() {
       @Override
@@ skipping 82 matching lines @@
         button.setLayoutData(gd);
         SWTFactory.setButtonDimensionHint(button);
         int index = buttonMap.size();
         buttonMap.put(index, button);
       }
 
       breakpointRadioButtons =
           new RadioButtonsLogic<Integer>(buttonMap, radioButtonsListener);
     }
 
-    InaccurateOptionControl inaccurateOptionControl =
-        new InaccurateOptionControl(composite, params.getScriptNameDescription());
+    LookupModeControl lookupModeControl =
+        new LookupModeControl(composite, params.getScriptNameDescription());
 
-    final RadioButtonsLogic<LookupAccurateness> inaccuratenessLogic =
-        inaccurateOptionControl.createLogic(radioButtonsListener);
+    final RadioButtonsLogic<LookupMode> lookupModeLogic =
+        lookupModeControl.createLogic(radioButtonsListener);
 
     return new TabElements() {
       @Override public StringFieldEditor getHost() {
         return debugHost;
       }
       @Override public IntegerFieldEditor getPort() {
         return debugPort;
       }
       @Override public BooleanFieldEditor getAddNetworkConsole() {
         return addNetworkConsole;
       }
       @Override public RadioButtonsLogic<Integer> getBreakpointRadioButtons() {
         return breakpointRadioButtons;
       }
-      @Override public RadioButtonsLogic<LookupAccurateness> getAccuratenessControl() {
-        return inaccuratenessLogic;
+      @Override public RadioButtonsLogic<LookupMode> getLookupMode() {
+        return lookupModeLogic;
       }
     };
   }
 
   public String getName() {
     return Messages.ChromiumRemoteTab_RemoteTabName;
   }
 
   public void initializeFrom(ILaunchConfiguration config) {
     for (TabField<?, ?> field : TAB_FIELDS) {
@@ skipping 172 matching lines @@
       }
       button.addSelectionListener(selectionListener);
     }
   }
 
   private interface TabElements {
     StringFieldEditor getHost();
     IntegerFieldEditor getPort();
     BooleanFieldEditor getAddNetworkConsole();
     RadioButtonsLogic<Integer> getBreakpointRadioButtons();
-    RadioButtonsLogic<LookupAccurateness> getAccuratenessControl();
+    RadioButtonsLogic<LookupMode> getLookupMode();
   }
 
   /**
    * A dialog window tab field description. It is a static description -- it has no reference to
    * a particular element instance.
    * @param <P> physical type of field as stored in config; used internally
    * @param <L> logical type of field used in runtime operations
    */
   private static class TabField<P, L> {
     private final String configAttributeName;
@@ skipping 225 matching lines @@
         new DefaultsProvider<String>() {
           @Override String getFallbackValue() {
             return Direction.MERGE.toString();
           }
           @Override String getInitialConfigValue(ChromiumRemoteTab dialog) {
             return null;
           }
         },
         ValueConverter.<String>getTrivial()));
 
-    list.add(new TabField<String, LookupAccurateness>(
-        LaunchParams.SOURCE_LOOKUP_ACCURATENESS, TypedMethods.STRING,
-        new FieldAccess<LookupAccurateness>() {
+    list.add(new TabField<String, LookupMode>(
+        LaunchParams.SOURCE_LOOKUP_MODE, TypedMethods.STRING,
+        new FieldAccess<LookupMode>() {
           @Override
-          void setValue(LookupAccurateness value, TabElements tabElements) {
-            tabElements.getAccuratenessControl().select(value);
+          void setValue(LookupMode value, TabElements tabElements) {
+            tabElements.getLookupMode().select(value);
           }
           @Override
-          LookupAccurateness getValue(TabElements tabElements) {
-            return tabElements.getAccuratenessControl().getSelected();
+          LookupMode getValue(TabElements tabElements) {
+            return tabElements.getLookupMode().getSelected();
           }
         },
-        new DefaultsProvider<LookupAccurateness>() {
-          @Override LookupAccurateness getFallbackValue() {
+        new DefaultsProvider<LookupMode>() {
+          @Override LookupMode getFallbackValue() {
             // TODO: support default value from eclipse variables.
-            return LookupAccurateness.DEFAULT_VALUE;
+            return LookupMode.DEFAULT_VALUE;
           }
-          @Override LookupAccurateness getInitialConfigValue(ChromiumRemoteTab dialog) {
-            return dialog.params.getNewConfigLookupAccurateness();
+          @Override LookupMode getInitialConfigValue(ChromiumRemoteTab dialog) {
+            return dialog.params.getNewConfigLookupMode();
           }
         },
-        LookupAccurateness.STRING_CONVERTER));
+        LookupMode.STRING_CONVERTER));
 
     TAB_FIELDS = Collections.unmodifiableList(list);
   }
 
   private static class SourceContainerChecker {
     public String check(ILaunchConfiguration config) {
-      LookupAccurateness accurateness;
+      LookupMode lookupMode;
       try {
-        accurateness = ChromiumSourceDirector.readLookupAccurateness(config);
+        lookupMode = ChromiumSourceDirector.readLookupMode(config);
       } catch (CoreException e) {
         ChromiumDebugPlugin.log(e);
         return null;
       }
-      if (accurateness != LookupAccurateness.INACCURATE) {
+      if (lookupMode != LookupMode.AUTO_DETECT) {
         return null;
       }
 
       ISourceLookupDirector director;
       try {
         director = read(config);
       } catch (CoreException e) {
         return null;
       }
       if (director == null) {
         return null;
       }
       for (ISourceContainer sourceContainer : director.getSourceContainers()) {
         if (sourceContainer instanceof SourceNameMapperContainer) {
-          return Messages.ChromiumRemoteTab_INACCURATE_CONTAINER_WARNING;
+          return Messages.ChromiumRemoteTab_AUTO_DETECT_CONTAINER_WARNING;
         }
       }
       return null;
     }
 
     private ISourceLookupDirector read(ILaunchConfiguration config) throws CoreException {
       String memento = config.getAttribute(
           ILaunchConfiguration.ATTR_SOURCE_LOCATOR_MEMENTO, (String)null);
       if (memento == null) {
         return null;
@@ skipping 16 matching lines @@
   private static GridLayout createHtmlStyleGridLayout(int numberOfColumns) {
     GridLayout layout = new GridLayout(numberOfColumns, false);
     layout.horizontalSpacing = 0;
     layout.verticalSpacing = 0;
     layout.marginWidth = 0;
     layout.marginHeight = 0;
     return layout;
   }
 
   /**
-   * Dialog UI group of 2 radio buttons for lookup accurateness mode.
+   * Dialog UI group of 2 radio buttons for lookup mode.
    */
-  private static class InaccurateOptionControl {
-    private final Map<LookupAccurateness, Button> buttons;
-    InaccurateOptionControl(Composite container, String scriptNameFormatDescription) {
-      buttons = new LinkedHashMap<LookupAccurateness, Button>();
+  private static class LookupModeControl {
+    private final Map<LookupMode, Button> buttons;
+    LookupModeControl(Composite container, String scriptNameFormatDescription) {
+      buttons = new LinkedHashMap<LookupMode, Button>();
       Group breakpointGroup = new Group(container, 0);
       breakpointGroup.setLayoutData(new GridData(GridData.FILL_HORIZONTAL));
       breakpointGroup.setText("Source look-up method for workspace files");
       breakpointGroup.setLayout(new GridLayout(1, false));
 
-      buttons.put(LookupAccurateness.ACCURATE, createButtonBlock(breakpointGroup,
-          "Accurate", "Full script names are used.",
+      buttons.put(LookupMode.EXACT_MATCH, createButtonBlock(breakpointGroup,
+          "Exact match", "Full script names are used.",
           "JavaScript Source Name Mapper must be set up in Source tab."));
-      buttons.put(LookupAccurateness.INACCURATE, createButtonBlock(breakpointGroup,
-          "Inaccurate", "Only short file names are used.",
-          "Actual script names are treated as: " + scriptNameFormatDescription));
+
+      buttons.put(LookupMode.AUTO_DETECT, createButtonBlock(breakpointGroup,
+          "Auto-detect", "Only short file names are used.",
+          "Actual script names are parsed as: " + scriptNameFormatDescription));
 
       addRadioButtonSwitcher(buttons.values());
     }
 
-    RadioButtonsLogic<LookupAccurateness> createLogic(RadioButtonsLogic.Listener listener) {
-      return new RadioButtonsLogic<LookupAccurateness>(buttons, listener);
+    RadioButtonsLogic<LookupMode> createLogic(RadioButtonsLogic.Listener listener) {
+      return new RadioButtonsLogic<LookupMode>(buttons, listener);
     }
 
     private static Button createButtonBlock(Composite parent, String buttonLabel,
         String descriptionLine1, String descriptionLine2) {
       Composite buttonComposite = new Composite(parent, SWT.NONE);
-      GridLayout gridLayout = createHtmlStyleGridLayout(2);
+      GridLayout gridLayout = createHtmlStyleGridLayout(3);
       buttonComposite.setLayout(gridLayout);
       Button button = new Button(buttonComposite, SWT.RADIO | SWT.NO_RADIO_GROUP);
-      button.setText(buttonLabel + "   ");
+      button.setText(buttonLabel);
+      Label padding = new Label(buttonComposite, SWT.NONE);
+      padding.setText("   ");
       Label descriptionLine1Label = new Label(buttonComposite, SWT.NONE);
       descriptionLine1Label.setText(descriptionLine1);
       // Extra label to fill a grid in layout.
       new Label(buttonComposite, SWT.NONE);
+      new Label(buttonComposite, SWT.NONE);
       Label descriptionLine2Label = new Label(buttonComposite, SWT.NONE);
       descriptionLine2Label.setText(descriptionLine2);
       return button;
     }
   }
 }