Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 739793004: Cleanup webkit DEPS list. (Closed)

Created:
6 years, 1 month ago by tfarina
Modified:
6 years, 1 month ago
Reviewers:
danakj, jamesr
CC:
chromium-reviews, darin-cc_chromium.org, danakj, darin (slow to review), jam, pilgrim_google, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup webkit DEPS list. BUG=338338 TEST=checkdeps R=jamesr@chromium.org,danakj@chromium.org TBR= Committed: https://crrev.com/b56ec36566d350a9fb6229761b8a808b504a037a Cr-Commit-Position: refs/heads/master@{#305124}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -40 lines) Patch
M webkit/DEPS View 1 chunk +7 lines, -37 lines 3 comments Download
D webkit/common/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
tfarina
PTAL
6 years, 1 month ago (2014-11-20 17:30:06 UTC) #1
danakj
https://codereview.chromium.org/739793004/diff/1/webkit/DEPS File webkit/DEPS (left): https://codereview.chromium.org/739793004/diff/1/webkit/DEPS#oldcode29 webkit/DEPS:29: # For gpu/ is this comment wrong now?
6 years, 1 month ago (2014-11-20 17:39:39 UTC) #3
tfarina
https://codereview.chromium.org/739793004/diff/1/webkit/DEPS File webkit/DEPS (left): https://codereview.chromium.org/739793004/diff/1/webkit/DEPS#oldcode29 webkit/DEPS:29: # For gpu/ On 2014/11/20 17:39:39, danakj wrote: > ...
6 years, 1 month ago (2014-11-20 17:46:06 UTC) #4
danakj
https://codereview.chromium.org/739793004/diff/1/webkit/DEPS File webkit/DEPS (left): https://codereview.chromium.org/739793004/diff/1/webkit/DEPS#oldcode29 webkit/DEPS:29: # For gpu/ On 2014/11/20 17:46:05, tfarina wrote: > ...
6 years, 1 month ago (2014-11-20 17:48:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739793004/1
6 years, 1 month ago (2014-11-20 18:01:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/25543)
6 years, 1 month ago (2014-11-20 18:07:26 UTC) #9
jamesr
lgtm
6 years, 1 month ago (2014-11-20 18:13:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739793004/1
6 years, 1 month ago (2014-11-21 00:36:18 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-21 00:40:17 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 00:40:52 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b56ec36566d350a9fb6229761b8a808b504a037a
Cr-Commit-Position: refs/heads/master@{#305124}

Powered by Google App Engine
This is Rietveld 408576698