chrome/browser/ui/views/frame/browser_view.cc - Issue 739793003: Close bubbles not on UpdateToolbar but when the activated tab is changed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 739793003: Close bubbles not on UpdateToolbar but when the activated tab is changed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 3ac592238f6223ebbd5af734c21589dd402cac62..52c7ea73c60b341d1cef5320b6650d8c85315513 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -74,6 +74,7 @@

#include "chrome/browser/ui/views/infobars/infobar_container_view.h"

#include "chrome/browser/ui/views/location_bar/location_bar_view.h"

#include "chrome/browser/ui/views/location_bar/location_icon_view.h"

+#include "chrome/browser/ui/views/location_bar/zoom_bubble_view.h"

#include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"

#include "chrome/browser/ui/views/profiles/avatar_menu_bubble_view.h"

#include "chrome/browser/ui/views/profiles/avatar_menu_button.h"

@@ -824,6 +825,9 @@ void BrowserView::OnActiveTabChanged(content::WebContents* old_contents,

// Update all the UI bits.

UpdateTitleBar();

+ TranslateBubbleView::CloseBubble();

+ ZoomBubbleView::CloseBubble();

}

void BrowserView::ZoomChangedForActiveTab(bool can_show_bubble) {

« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('j') | no next file with comments »