Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 739793003: Close bubbles not on UpdateToolbar but when the activated tab is changed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 void ConfirmAddSearchProvider(TemplateURL* template_url, 311 void ConfirmAddSearchProvider(TemplateURL* template_url,
312 Profile* profile) override; 312 Profile* profile) override;
313 void ShowUpdateChromeDialog() override; 313 void ShowUpdateChromeDialog() override;
314 void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) override; 314 void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) override;
315 void ShowBookmarkAppBubble(const WebApplicationInfo& web_app_info, 315 void ShowBookmarkAppBubble(const WebApplicationInfo& web_app_info,
316 const std::string& extension_id) override; 316 const std::string& extension_id) override;
317 void ShowTranslateBubble(content::WebContents* contents, 317 void ShowTranslateBubble(content::WebContents* contents,
318 translate::TranslateStep step, 318 translate::TranslateStep step,
319 translate::TranslateErrors::Type error_type, 319 translate::TranslateErrors::Type error_type,
320 bool is_user_gesture) override; 320 bool is_user_gesture) override;
321 void CloseTranslateBubble() override;
321 #if defined(ENABLE_ONE_CLICK_SIGNIN) 322 #if defined(ENABLE_ONE_CLICK_SIGNIN)
322 void ShowOneClickSigninBubble( 323 void ShowOneClickSigninBubble(
323 OneClickSigninBubbleType type, 324 OneClickSigninBubbleType type,
324 const base::string16& email, 325 const base::string16& email,
325 const base::string16& error_message, 326 const base::string16& error_message,
326 const StartSyncCallback& start_sync_callback) override; 327 const StartSyncCallback& start_sync_callback) override;
327 #endif 328 #endif
328 // TODO(beng): Not an override, move somewhere else. 329 // TODO(beng): Not an override, move somewhere else.
329 void SetDownloadShelfVisible(bool visible); 330 void SetDownloadShelfVisible(bool visible);
330 bool IsDownloadShelfVisible() const override; 331 bool IsDownloadShelfVisible() const override;
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
700 scoped_ptr<ImmersiveModeController> immersive_mode_controller_; 701 scoped_ptr<ImmersiveModeController> immersive_mode_controller_;
701 702
702 scoped_ptr<WebContentsCloseHandler> web_contents_close_handler_; 703 scoped_ptr<WebContentsCloseHandler> web_contents_close_handler_;
703 704
704 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_; 705 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_;
705 706
706 DISALLOW_COPY_AND_ASSIGN(BrowserView); 707 DISALLOW_COPY_AND_ASSIGN(BrowserView);
707 }; 708 };
708 709
709 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 710 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698