Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_cocoa.h

Issue 739793003: Close bubbles not on UpdateToolbar but when the activated tab is changed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_
6 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_ 6 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_
7 7
8 #include "base/mac/scoped_nsobject.h" 8 #include "base/mac/scoped_nsobject.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "chrome/browser/extensions/extension_keybinding_registry.h" 10 #include "chrome/browser/extensions/extension_keybinding_registry.h"
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 void ConfirmAddSearchProvider(TemplateURL* template_url, 100 void ConfirmAddSearchProvider(TemplateURL* template_url,
101 Profile* profile) override; 101 Profile* profile) override;
102 void ShowUpdateChromeDialog() override; 102 void ShowUpdateChromeDialog() override;
103 void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) override; 103 void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) override;
104 void ShowBookmarkAppBubble(const WebApplicationInfo& web_app_info, 104 void ShowBookmarkAppBubble(const WebApplicationInfo& web_app_info,
105 const std::string& extension_id) override; 105 const std::string& extension_id) override;
106 void ShowTranslateBubble(content::WebContents* contents, 106 void ShowTranslateBubble(content::WebContents* contents,
107 translate::TranslateStep step, 107 translate::TranslateStep step,
108 translate::TranslateErrors::Type error_type, 108 translate::TranslateErrors::Type error_type,
109 bool is_user_gesture) override; 109 bool is_user_gesture) override;
110 void CloseTranslateBubble() override;
110 #if defined(ENABLE_ONE_CLICK_SIGNIN) 111 #if defined(ENABLE_ONE_CLICK_SIGNIN)
111 void ShowOneClickSigninBubble( 112 void ShowOneClickSigninBubble(
112 OneClickSigninBubbleType type, 113 OneClickSigninBubbleType type,
113 const base::string16& email, 114 const base::string16& email,
114 const base::string16& error_message, 115 const base::string16& error_message,
115 const StartSyncCallback& start_sync_callback) override; 116 const StartSyncCallback& start_sync_callback) override;
116 #endif 117 #endif
117 bool IsDownloadShelfVisible() const override; 118 bool IsDownloadShelfVisible() const override;
118 DownloadShelf* GetDownloadShelf() override; 119 DownloadShelf* GetDownloadShelf() override;
119 void ConfirmBrowserCloseWithPendingDownloads( 120 void ConfirmBrowserCloseWithPendingDownloads(
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 NSWindow* window() const; // Accessor for the (current) |NSWindow|. 176 NSWindow* window() const; // Accessor for the (current) |NSWindow|.
176 177
177 Browser* browser_; // weak, owned by controller 178 Browser* browser_; // weak, owned by controller
178 BrowserWindowController* controller_; // weak, owns us 179 BrowserWindowController* controller_; // weak, owns us
179 base::scoped_nsobject<NSString> pending_window_title_; 180 base::scoped_nsobject<NSString> pending_window_title_;
180 ui::WindowShowState initial_show_state_; 181 ui::WindowShowState initial_show_state_;
181 NSInteger attention_request_id_; // identifier from requestUserAttention 182 NSInteger attention_request_id_; // identifier from requestUserAttention
182 }; 183 };
183 184
184 #endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_ 185 #endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698