Issue 739753003: Store handles with data inside Messages when Connector receives messages

Issue 739753003: Store handles with data inside Messages when Connector receives messages (Closed)

Created:
6 years ago by etiennej

Modified:
6 years ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Request the right number of handles when Connector receives messages R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/94b37653b3623926cd68cfa9d62ffcdae4a953d7

Patch Set 2 : #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	mojo/public/python/mojo/bindings/messaging.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	mojo/python/tests/messaging_unittest.py	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

qsr

The comment for the CL is not accurate. The issue was not that we didn't ...

6 years ago (2014-12-10 10:54:44 UTC) #2

etiennej

https://codereview.chromium.org/739753003/diff/1/mojo/python/tests/messaging_unittest.py File mojo/python/tests/messaging_unittest.py (right): https://codereview.chromium.org/739753003/diff/1/mojo/python/tests/messaging_unittest.py#newcode84 mojo/python/tests/messaging_unittest.py:84: new_handles = None On 2014/12/10 10:54:44, qsr wrote: > ...

6 years ago (2014-12-10 11:35:45 UTC) #4

etiennej

6 years ago (2014-12-10 13:54:25 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
94b37653b3623926cd68cfa9d62ffcdae4a953d7 (presubmit successful).

Expand Messages | Collapse Messages