Issue 739743003: [turbofan] Smartify typing of NumberToInt32 and NumberToUint32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 739743003: [turbofan] Smartify typing of NumberToInt32 and NumberToUint32. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer

Modified:
6 years, 1 month ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

[turbofan] Smartify typing of NumberToInt32 and NumberToUint32. According to ES5 9.5 and 9.6, NaN, -inf, +inf, -0 and 0 all truncate to zero for both ToInt32 and ToUint32, so we can be a lot smarter in the typer, loosing less information upon truncation (i.e. x | 0 and x >>> 0). R=jarin@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/a39b2f50083bcbe53668a4ee04cbf55d0ac570b2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -11 lines)			Patch
	M	src/compiler/typer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/compiler/typer.cc	View		4 chunks	+24 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

6 years, 1 month ago (2014-11-19 07:40:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a39b2f50083bcbe53668a4ee04cbf55d0ac570b2 (presubmit successful).