Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 739743003: [turbofan] Smartify typing of NumberToInt32 and NumberToUint32. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Smartify typing of NumberToInt32 and NumberToUint32. According to ES5 9.5 and 9.6, NaN, -inf, +inf, -0 and 0 all truncate to zero for both ToInt32 and ToUint32, so we can be a lot smarter in the typer, loosing less information upon truncation (i.e. x | 0 and x >>> 0). R=jarin@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/a39b2f50083bcbe53668a4ee04cbf55d0ac570b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M src/compiler/typer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 4 chunks +24 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 1 month ago (2014-11-19 05:18:59 UTC) #1
Jarin
lgtm
6 years, 1 month ago (2014-11-19 07:24:53 UTC) #2
Benedikt Meurer
6 years, 1 month ago (2014-11-19 07:40:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a39b2f50083bcbe53668a4ee04cbf55d0ac570b2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698