Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 739743002: RenderGrid needs to pop its LayoutState before relayout. (Closed)

Created:
6 years, 1 month ago by mstensho (USE GERRIT)
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, chromiumbugtracker_adobe.com, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, Manuel Rego, svillar, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

RenderGrid needs to pop its LayoutState before relayout. All other renderers do this, and so should RenderGrid. If the new layout affects the presence of scrollbars (if overflow-[xy] is auto), another layout pass may be required. Pushing two LayoutState objects for the same object is unhealthy inside multicol, because the stack in RenderFlowThread is implemented using a hash map, for some reason. BUG=414456 R=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -12 lines) Patch
A LayoutTests/fast/multicol/grid-with-auto-scrollbar-crash.html View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/grid-with-auto-scrollbar-crash-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderFlowThread.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 chunk +16 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mstensho (USE GERRIT)
I find it hard to understand that RenderFlowThread uses a hash map to implement a ...
6 years, 1 month ago (2014-11-18 23:08:41 UTC) #1
chrishtr
Seems logical, but I'm not as expert in this code. Adding Levi.
6 years, 1 month ago (2014-11-18 23:43:24 UTC) #3
leviw_travelin_and_unemployed
I'm not sure about the choice in RenderFlowThread... Sounds like you could fix that, too. ...
6 years, 1 month ago (2014-11-19 00:11:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739743002/1
6 years, 1 month ago (2014-11-19 07:46:57 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 08:58:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185577

Powered by Google App Engine
This is Rietveld 408576698