Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 739733002: Add raymes to mime_handler_view OWNERS (Closed)

Created:
6 years, 1 month ago by raymes
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add raymes to mime_handler_view OWNERS This also moves extensions/renderer/guest_view/mime_handler_view_container.h into its own folder. Committed: https://crrev.com/20c67ab945da4f2cd3292c6634e49e1b558d2c3b Cr-Commit-Position: refs/heads/master@{#305073}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -191 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/guest_view/mime_handler_view/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/renderer/guest_view/mime_handler_view/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 1 chunk +1 line, -1 line 0 comments Download
D extensions/renderer/guest_view/mime_handler_view_container.h View 1 chunk +0 lines, -84 lines 0 comments Download
D extensions/renderer/guest_view/mime_handler_view_container.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M extensions/shell/renderer/shell_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
raymes
Hey Fady PTAL
6 years, 1 month ago (2014-11-18 23:12:21 UTC) #2
Fady Samuel
lgtm! :D
6 years, 1 month ago (2014-11-18 23:15:33 UTC) #3
raymes
+OWNERS thestig for chrome/* benwells for extensions/*
6 years, 1 month ago (2014-11-18 23:40:35 UTC) #5
Lei Zhang
chrome/ lgtm
6 years, 1 month ago (2014-11-18 23:41:55 UTC) #6
benwells
lgtm
6 years, 1 month ago (2014-11-20 04:18:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739733002/20001
6 years, 1 month ago (2014-11-20 19:30:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-20 20:23:48 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 20:24:51 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/20c67ab945da4f2cd3292c6634e49e1b558d2c3b
Cr-Commit-Position: refs/heads/master@{#305073}

Powered by Google App Engine
This is Rietveld 408576698