Deprecate RegisterProtocolFactory/(Un)RegisterInterceptor.

Deprecate RegisterProtocolFactory/(Un)RegisterInterceptor.

Mark those APIs as private and friend existing uses.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92992

[willchan no longer on Chromium, 2011-07-17 15:11:32]

eroman: Please review everything. I dunno if you find this friend whitelist
approach a bit draconian, but I'm a bit tired of playing catch up with new
usages.

Need OWNERS approval for:
content: brettw/jam
extensions: mpcomplete/asargent
webkit/*: michaeln/kinuko
chrome_frame: ananta

FYI:
component_updater: cpu

[ananta, 2011-07-18 09:49:42]

chrome frame changes :- LGTM

[asargent_no_longer_on_chrome, 2011-07-18 17:15:57]

extensions part LGTM

http://codereview.chromium.org/7397008/diff/2001/net/url_request/url_request.h
File net/url_request/url_request.h (right):

http://codereview.chromium.org/7397008/diff/2001/net/url_request/url_request....
net/url_request/url_request.h:164: // explicitly friended here and should be
removed over time.
nit: please include a note here about what people should do instead of using a
RequestInterceptor, for the class of problems they used to use this for. (e.g.
"I want to write a test where I return some dynamically generated content in
response to an url request".)

[brettw, 2011-07-18 17:34:12]

content LGTM

[michaeln, 2011-07-18 18:39:18]

webkit/* LGTM

[eroman, 2011-07-18 22:24:03]

LGTM.

Note that I am not enthusiastic about exposing this via friending, since it
pollutes the "net/" module with references to "chrome/".

I respect that this is a clever way of requiring net/ OWNERS approval before
peeps can introduce new dependences on it. But I suspect a straight up name
change to someting like DONTUSEME_RegisterProtocolFactory() or
DEPRECTED_RegisterProtocolFactory() would achieve the same results (by raising
questions on codereviews that tried to use it). Maybe I am just too trusting in
people's goodness.

Fine as-is for commit.

http://codereview.chromium.org/7397008/diff/2001/content/browser/child_proces...
File content/browser/child_process_security_policy_unittest.cc (right):

http://codereview.chromium.org/7397008/diff/2001/content/browser/child_proces...
content/browser/child_process_security_policy_unittest.cc:181:
&net::URLRequestTestJob::Factory);
indentation.

[commit-bot: I haz the power, 2011-07-19 09:31:13]

Change committed as 92992