Create GrOptDrawState before recording draw in GrInOrderDrawBuffer

include/gpu/GrProgramElement.h

Index: include/gpu/GrProgramElement.h
diff --git a/include/gpu/GrProgramElement.h b/include/gpu/GrProgramElement.h
index 2cdd1cc5635014e81d3362b4fb8ca3a0600abca7..e1adcc31f726eccd7e68754ea80b371ec2685a9f 100644
--- a/include/gpu/GrProgramElement.h
+++ b/include/gpu/GrProgramElement.h
@@ -35,10 +35,11 @@ public:
     }
 
     void ref() const {
+        this->validate();
         // Once the ref cnt reaches zero it should never be ref'ed again.
         SkASSERT(fRefCnt > 0);
-        this->validate();
         ++fRefCnt;
+        this->validate();
     }
 
     void unref() const {
@@ -47,10 +48,12 @@ public:
         if (0 == fRefCnt) {
             if (0 == fPendingExecutions) {
                 SkDELETE(this);
+                return;
             } else {
                 this->removeRefs();
             }
         }
+        this->validate();
     }
 
     /**
@@ -80,11 +83,33 @@ protected:
 private:
     static uint32_t CreateUniqueID();
 
-    void convertRefToPendingExecution() const;
+    void addPendingExecution() const {
+        this->validate();
+        SkASSERT(fRefCnt > 0);
+        if (0 == fPendingExecutions) {
+            this->addPendingIOs();
+        }
+        ++fPendingExecutions;
+        this->validate();
+    }
 
-    void completedExecution() const;
+    void completedExecution() const {
+        this->validate();
+        --fPendingExecutions;
+        if (0 == fPendingExecutions) {
+            if (0 == fRefCnt) {
+                SkDELETE(this);
+                return;
+            } else {
+                this->pendingIOComplete();
+            }
+        }
+        this->validate();

[joshualitt, 2014/11/19 14:22:39]

Is there anyway to refactor this->validate so we  don't need two calls?  I
realize it only effects debug and maybe there isn't.

[bsalomon, 2014/11/19 15:04:43]

It doesn't need to be called twice (or at all)... I was just doing pre- and
post- calls to be sure the state was correct before and after the call..

I could add and AutoValidate that validates in its cons and ~, but I think it
might increase the total line count

[bsalomon, 2014/11/19 15:20:06]

Actually I can't do that since some of the calls delete "this" before returning
and thus can't validate afterwards.

+    }
 
     void removeRefs() const;
+    void addPendingIOs() const;
+    void pendingIOComplete() const;
 
     mutable int32_t fRefCnt;
     // Count of deferred executions not yet issued to the 3D API.
@@ -93,8 +118,8 @@ private:
 
     SkSTArray<4, const GrGpuResourceRef*, true> fGpuResources;
 
-    // Only this class can access convertRefToPendingExecution() and completedExecution().
-    template <typename T> friend class GrProgramElementRef;
+    // Only this class can access addPendingExecution() and completedExecution().
+    template <typename T> friend class GrPendingProgramElement;
 
     typedef SkNoncopyable INHERITED;
 };