Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5694)

Unified Diff: chrome/browser/ui/gtk/tab_contents/render_view_context_menu_gtk.h

Issue 73963004: [Chromium] Adding Writing direction to the context menu for linux gtk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: changes under TOOLKIT_GTK Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/tab_contents/render_view_context_menu_gtk.h
diff --git a/chrome/browser/ui/gtk/tab_contents/render_view_context_menu_gtk.h b/chrome/browser/ui/gtk/tab_contents/render_view_context_menu_gtk.h
index aeb8689d87e5e6fb4430de9ffbc6e6a77d9d86eb..22f065b8d86e29b6e4f79319c4c6baa822bc6c3d 100644
--- a/chrome/browser/ui/gtk/tab_contents/render_view_context_menu_gtk.h
+++ b/chrome/browser/ui/gtk/tab_contents/render_view_context_menu_gtk.h
@@ -31,6 +31,11 @@ class RenderViewContextMenuGtk : public RenderViewContextMenu,
// Menu::Delegate implementation ---------------------------------------------
virtual bool AlwaysShowIconForCmd(int command_id) const OVERRIDE;
+ // SimpleMenuModel::Delegate implementation.
+ virtual void ExecuteCommand(int command_id, int event_flags) OVERRIDE;
+ virtual bool IsCommandIdChecked(int command_id) const OVERRIDE;
+ virtual bool IsCommandIdEnabled(int command_id) const OVERRIDE;
+
// RenderViewContextMenuDelegate implementation ------------------------------
virtual void UpdateMenuItem(int command_id,
bool enabled,
@@ -45,8 +50,15 @@ class RenderViewContextMenuGtk : public RenderViewContextMenu,
virtual bool GetAcceleratorForCommandId(
int command_id,
ui::Accelerator* accelerator) OVERRIDE;
+ virtual void AppendPlatformEditableItems() OVERRIDE;
private:
+ // Adds writing direction submenu.
+ void AppendBidiSubMenu();
+
+ // Model for the BiDi input submenu.
+ ui::SimpleMenuModel bidi_submenu_model_;
+
scoped_ptr<MenuGtk> menu_gtk_;
uint32_t triggering_event_time_;
};
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/gtk/tab_contents/render_view_context_menu_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698