Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 73963004: [Chromium] Adding Writing direction to the context menu for linux gtk (Closed)

Created:
7 years, 1 month ago by pals
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Dirk Pranke, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adding Writing direction to the context menu for linux gtk. Blink side change is here https://codereview.chromium.org/66313007/ This CL takes care of the context menu on Linux Gtk. Most of the changes are copied from Writing direction context menu entry implementation on MacOSX. There seems to be no way to change writing direction on Aura. I would like create a separate CL to implement the same on Aura. BUG=91178 TBR=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236515

Patch Set 1 #

Total comments: 2

Patch Set 2 : changes under TOOLKIT_GTK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -15 lines) Patch
M chrome/app/chrome_command_ids.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_contents/render_view_context_menu_gtk.h View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/tab_contents/render_view_context_menu_gtk.cc View 3 chunks +84 lines, -1 line 0 comments Download
M content/common/view_messages.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/context_menu_params.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/common/context_menu_params.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/context_menu_params_builder.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
pals
PTAL
7 years, 1 month ago (2013-11-19 13:09:19 UTC) #1
eseidel
Linux recently switched off of the Gtk chrome UI onto the Aura chrome UI, so ...
7 years, 1 month ago (2013-11-19 19:10:11 UTC) #2
jochen (gone - plz use gerrit)
Linux just changed back to gtk for the time being
7 years, 1 month ago (2013-11-19 19:15:38 UTC) #3
Elliot Glaysher
Mostly lgtm. That said, I give slightly better than even odds of this gtk code ...
7 years, 1 month ago (2013-11-19 19:24:24 UTC) #4
pals
Updated the patch. https://codereview.chromium.org/73963004/diff/1/content/common/view_messages.h File content/common/view_messages.h (right): https://codereview.chromium.org/73963004/diff/1/content/common/view_messages.h#newcode183 content/common/view_messages.h:183: #if defined(OS_MACOSX) || defined(OS_LINUX) On 2013/11/19 ...
7 years, 1 month ago (2013-11-20 05:26:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/73963004/70001
7 years, 1 month ago (2013-11-20 05:29:38 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=37141
7 years, 1 month ago (2013-11-20 05:47:45 UTC) #7
pals
Owner's review : +cpu for chrome/app/chrome_command_ids.h +piman for content/* PTAL. Thanks
7 years, 1 month ago (2013-11-20 06:32:36 UTC) #8
piman
LGTM for content/
7 years, 1 month ago (2013-11-20 19:29:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/73963004/70001
7 years, 1 month ago (2013-11-21 06:33:02 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=227362
7 years, 1 month ago (2013-11-21 10:11:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/73963004/70001
7 years, 1 month ago (2013-11-21 11:54:31 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-11-21 13:10:14 UTC) #13
Message was sent while issue was closed.
Change committed as 236515

Powered by Google App Engine
This is Rietveld 408576698